[ELY-2548] BasicAuthenticationMechanism should return FORBIDDEN instead of UNAUTHORIZED #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ad of UNAUTHORIZED
…ad of UNAUTHORIZED
Skyllarr
approved these changes
Mar 19, 2024
| ((AuthorizeCallback) callback).setAuthorized(false); | ||
| } else if(username.equals(((AuthorizeCallback) callback).getAuthenticationID()) && | ||
| username.equals(((AuthorizeCallback) callback).getAuthorizationID())) { | ||
| ((AuthorizeCallback) callback).setAuthorized(true); | ||
| } else { | ||
| if (username.equals(((AuthorizeCallback) callback).getAuthenticationID()) && |
There was a problem hiding this comment.
@darranl This is a minor but these conditions can be simplified, we can merge this now and then I can create a good-first-issue to simplify this
There was a problem hiding this comment.
IMO I would say go ahead and raise a good first issue - this is not my fix I just addressed a merge conflict so we can clear some of the PR queue backlog.
|
Adding my approval (for the original PR as this PR is just to fix a merge conflict) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a resubmission of #1899 to address the merge conflict.
https://issues.redhat.com/browse/ELY-2548
@Skyllarr FYI you had approved the original submission of this PR.