Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WFLY-18925: Flattened Quickstart READMEs #854

Merged
merged 1 commit into from
Jan 24, 2024
Merged

WFLY-18925: Flattened Quickstart READMEs #854

merged 1 commit into from
Jan 24, 2024

Conversation

theashiot
Copy link

@theashiot theashiot commented Jan 22, 2024 •
edited by emmartins
Loading

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Jan 22, 2024

Hi @theashiot. Thanks for your PR.

I'm waiting for a wildfly member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

emmartins
emmartins requested changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@emmartins emmartins left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also remove the README.adocs, and squash the commits into a single one.

@emmartins emmartins changed the title Wfly 18925 WFLY-18925: Flattened Quickstart READMEs Jan 24, 2024
@theashiot theashiot force-pushed the WFLY-18925 branch 4 times, most recently from ce637bc to b545388 Compare January 24, 2024 18:30
@emmartins emmartins marked this pull request as ready for review January 24, 2024 18:32
@emmartins emmartins merged commit b20c23c into wildfly:main Jan 24, 2024
84 of 86 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmartins emmartins emmartins approved these changes

Assignees
No one assigned
Labels
needs-ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theashiot @emmartins