Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator SDK Upgrade to v1.3.2 #219

Merged
merged 46 commits into from
Jul 26, 2022
Merged

Operator SDK Upgrade to v1.3.2 #219

merged 46 commits into from
Jul 26, 2022

Conversation

yersan
Copy link
Collaborator

@yersan yersan commented Feb 22, 2022

  • Initial work for SDK upgrade

@yersan
Copy link
Collaborator Author

yersan commented Jul 25, 2022

At the moment, the testsuite is throwing the following error from time to time, which delays the execution of the transaction recovery process, which results in a longer test execution that makes the testsuite to fail:

2022-07-25T10:48:43.165Z	ERROR	controllers.WildFlyServer	Failures during scaling down recovery processing	{"name": "wildfly-op-test-ns/wildfly-server-scale-down", "Desired replica size": 1, "Number of pods to be removed": 1, "error": "Failed to verify if the transaction subsystem is available. Error: Cannot execute management operation ':read-children-names(child-type=subsystem)' at pod wildfly-server-scale-down-0, error: Cannot decode JBoss CLI '${JBOSS_HOME}/bin/jboss-cli.sh --output-json -c --commands=':read-children-names(child-type=subsystem)'' executed on pod wildfly-server-scale-down-0 return data 'Failed to connect to the controller: The controller is not available at localhost:9990: java.net.ConnectException: WFLYPRT0053: Could not connect to remote+http://localhost:9990. The connection failed: WFLYPRT0053: Could not connect to remote+http://localhost:9990. The connection failed: Connection refused\n' to JSON. Cause: Fail to parse reader data to JSON, error: invalid character 'F' looking for beginning of value"}
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).reconcileHandler
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:298
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).processNextWorkItem
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:253
sigs.k8s.io/controller-runtime/pkg/internal/controller.(*Controller).Start.func1.2
	/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/internal/controller/controller.go:216
k8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext.func1
	/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:185
k8s.io/apimachinery/pkg/util/wait.BackoffUntil.func1
	/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:155
k8s.io/apimachinery/pkg/util/wait.BackoffUntil
	/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:156
k8s.io/apimachinery/pkg/util/wait.JitterUntil
	/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:133
k8s.io/apimachinery/pkg/util/wait.JitterUntilWithContext
	/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:185
k8s.io/apimachinery/pkg/util/wait.UntilWithContext
	/go/pkg/mod/k8s.io/[email protected]/pkg/util/wait/wait.go:99

This is currently under investigation.

@yersan
Copy link
Collaborator Author

yersan commented Jul 26, 2022

This is currently under investigation.

The reason was we were not using default readiness probes, so the testsuite was invoking the scale down without waiting until the applications were ready

@jmesnil jmesnil linked an issue Jul 26, 2022 that may be closed by this pull request
@jmesnil jmesnil merged commit 59b2b47 into wildfly:main Jul 26, 2022
@jmesnil
Copy link
Member

jmesnil commented Jul 26, 2022

@yersan thank you so much for that work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade Operator SDK to the latest version
2 participants