[226] Use patch instead of update to change pod labels #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmesnil
reviewed
Jun 17, 2022
pkg/resources/actions.go
Outdated
| return err | ||
| } | ||
|
|
||
| logger.Info("Patched resource") |
There was a problem hiding this comment.
@yersan should this be logged at Debug level?
There was a problem hiding this comment.
Good point, it can be a debug level instead, I just followed the same pattern we had for the other actions, but it is very verbose indeed.
There was a problem hiding this comment.
@jmesnil I've changed the message to debug level for the trace that confirms the action taken. There is no need to show it as info, if the operation fails an error is logged, otherwise, we can assume it was executed successfully, no need to log such a confirmation
…te/read/update/pacth/delete) taken on a resource
jmesnil
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #226