Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port EcoMap to Lonboard backend #189

Merged
merged 30 commits into from
Jul 3, 2024
Merged

Port EcoMap to Lonboard backend #189

merged 30 commits into from
Jul 3, 2024

Conversation

atmorling
Copy link
Contributor

Closes #165
Switches out the folium backend in favour of our lonboard fork

@atmorling
first cut of lonboard drop-in
34a920e
@atmorling
adding zoom_to_bounds
6bce594
@atmorling
png widget + add local geotiff
f3169a0
@atmorling
fix zoom to bounds flow
a24d0fd
@atmorling
first cut convert tiff to png
7c3d797
@atmorling
fix ee.Geometry path
23a693b
@atmorling
cleanup and static mode
f79abac
@atmorling
some integration tweaks
86a06a5
@atmorling
support named xyz services dict from contrib
19b47ce
@atmorling
use viz_layer
4e92d2a
@atmorling
Merge branch 'master' into 165/lonboard
b01b1c8
@atmorling
first pass of explore() overide change
ba62ec5
@atmorling
named tile layer changes
573d64f
@atmorling
speedmap port
f018510
@atmorling
add docs for new ecomap
1abf2c1
@atmorling
tests and pil support
2cea59b
@atmorling
fix breaking change in matplotlib 3.9.0
43a3117
@atmorling
add lonboard fork as dep
e51425e
@atmorling
replace folium ecomap with lonboard
d77d7e9
@atmorling
remove contrib/foliummap
c26d026
@atmorling
support applying cmap to a column in add_gdf()
119579a
@atmorling
notebook updates
838ed6a
@atmorling
fix environment.yml
cf17368
cisaacstern
cisaacstern reviewed Jun 26, 2024
View reviewed changes
Copy link
Contributor

@cisaacstern cisaacstern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found one typo and had one question, below.

Don't have other major insight/review here, but figured I'd my one question out in the mix.

tests/test_ecomap.py Outdated Show resolved Hide resolved
ecoscope/__init__.py Outdated Show resolved Hide resolved
@atmorling @cisaacstern
Update tests/test_ecomap.py
1473053 
Co-authored-by: Charles Stern <[email protected]>
@cisaacstern
Copy link
Contributor

@walljcg, based on discussion at standup today, everyone feels good to merge this, but we will wait until you've had a chance to weigh in, in case you want to do further review.

walljcg
walljcg approved these changes Jul 2, 2024
View reviewed changes
Copy link
Collaborator

@walljcg walljcg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks Great Alex! Thank-you!

@atmorling atmorling merged commit db5fe0c into wildlife-dynamics:master Jul 3, 2024
3 checks passed
@atmorling atmorling mentioned this pull request Jul 6, 2024
Open
@atmorling atmorling added the changelog-breaking Flag breaking changes label Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cisaacstern cisaacstern cisaacstern left review comments

@walljcg walljcg walljcg approved these changes

Assignees
No one assigned
Labels
changelog-breaking Flag breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Port EcoMap to forked Lonboard backend
3 participants
@atmorling @cisaacstern @walljcg