-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regression in recent releases #93
Labels
Comments
I'm AFK until Monday, but will look at it first thing then; I suspect I
know what's happening and how to resolve it.
…On May 4, 2017 11:27 AM, "William Durand" ***@***.***> wrote:
Copy/paste from #92 <#92>:
Hi @willdurand <https://github.com/willdurand>, @weierophinney
<https://github.com/weierophinney>! This PR and the new release (2.3)
breaks our test suite on api-platform/core. See https://travis-ci.org/api-
platform/core/jobs/228775063 for example.
I have this accept header: application/hal+json.
My priorities are:
[0] => "application/ld+json"
[1] => "application/hal+json"
[2] => "application/xml"
[3] => "text/xml"
[4] => "application/json"
[5] => "text/html"
Then, the AbstractNegotiator::getBest() method now returns
application/ld+json instead of application/hal+json before.
It looks like something is not working properly here, nop? Thanks.
(Ping @dunglas <https://github.com/dunglas>)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#93>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABlV02sS1PmtrCFlLgDo_Ft2TlU3Zq2ks5r2gpjgaJpZM4NQ-q3>
.
|
weierophinney
added a commit
to weierophinney/Negotiation
that referenced
this issue
May 8, 2017
Fixes willdurand#93. If there are no wildcard segments in either the subtype or + segment of either the Accept header or priority, do not attempt to compare them. Adds more tests for willdurand#92 as well, using `*` subtypes in both the Accept header and priorities, to validate that different combinations work as expected.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Copy/paste from #92:
Hi @willdurand, @weierophinney! This PR and the new release (2.3) breaks our test suite on api-platform/core. See https://travis-ci.org/api-platform/core/jobs/228775063 for example.
I have this accept header: application/hal+json.
My priorities are:
[0] => "application/ld+json"
[1] => "application/hal+json"
[2] => "application/xml"
[3] => "text/xml"
[4] => "application/json"
[5] => "text/html"
Then, the AbstractNegotiator::getBest() method now returns application/ld+json instead of application/hal+json before.
It looks like something is not working properly here, nop? Thanks.
(Ping @dunglas)
The text was updated successfully, but these errors were encountered: