Add missed fallback to generic language (in LanguageNegotiator)
#113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rtm-ctrlz is it a fix for #102? |
|
@Seb33300 yes, this PR should fix it |
|
Ping @willdurand, if you could merge this PR it could be very helpfull since branch 2.x doesn't support PHP 8 so we cannot rely on it anymore. BTW, this will fix all of the language related issues: #103, #102, #80 Thank you |
willdurand
force-pushed
the
fix-v3-generic-language
branch
from
8843752
to
baa2ec6
Compare
willdurand
changed the title
LanguageNegotiator)
|
Super sorry for not having merged this patch earlier.. I'll release a new version soon. |
This was referenced Jan 30, 2022
Closed
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same fix as #65 but for current version