Skip to content

Commit

Permalink
test: disable check on second remote access param
Browse files Browse the repository at this point in the history
The check failed sporadically but more than often enough on CI under high load.
The spy connection is just too racy. That holds for all signal spies but here
it really happens too often.

Long-term we need to find a general solution for this problem. That is also a
prerequisite for solving issue #12.

(cherry picked from commit e44986d)
  • Loading branch information
romangg committed Apr 1, 2020
1 parent 5a2ac99 commit c2065ba
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion autotests/client/test_remote_access.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -293,8 +293,12 @@ void RemoteAccessTest::testSendReleaseMultiple()
QVERIFY(paramsObtainedSpy1.size() == 1 || paramsObtainedSpy1.wait());
QCOMPARE(paramsObtainedSpy1.size(), 1);

// TODO: This signal spy connection is still too racy and fails too often under high load on CI.
// For now disable the check and try to find a solution as part of issue #12.
#if 0
QVERIFY(paramsObtainedSpy2.size() == 1 || paramsObtainedSpy2.wait());
QCOMPARE(paramsObtainedSpy2.size(), 1);
#endif

// release
QSignalSpy bufferReleasedSpy(m_remoteAccessInterface, &RemoteAccessManagerInterface::bufferReleased);
Expand Down Expand Up @@ -440,7 +444,7 @@ void RemoteAccessTest::testSendClientGone()

void RemoteAccessTest::testSendReceiveClientGone()
{
// this test verifies that when buffer is sent, received and client is gone,
// this test verifies that when buffer is sent, received and client is gone,
// both client and server will release buffer correctly
QVERIFY(!m_remoteAccessInterface->isBound());
auto *client = new MockupClient(this);
Expand Down

0 comments on commit c2065ba

Please sign in to comment.