fix:[CDS-81070]: Jenkins Job Parameters encoding

wings-software · Oct 11, 2023 · 6f5fd54 · 6f5fd54
1 parent 99e5fa7
commit 6f5fd54
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/jenkins-client/src/main/java/com/offbytwo/jenkins/model/Job.java b/jenkins-client/src/main/java/com/offbytwo/jenkins/model/Job.java
@@ -12,6 +12,8 @@
 import java.io.IOException;
 import java.io.InputStream;
 import java.net.URI;
+import java.net.URLEncoder;
+import java.nio.charset.StandardCharsets;
 import java.util.Map;
 import java.util.function.Function;
 import java.util.stream.Collectors;
@@ -144,9 +146,8 @@ public QueueReference build(Map<String, String> params, Map<String, File> filePa
      */
     public QueueReference build(Map<String, String> params, Map<String, File> fileParams, boolean crumbFlag) throws IOException {
         String qs = params.entrySet().stream()
-                .map(s -> s.getKey() + "=" + s.getValue())
-                .collect(Collectors.joining("&"));
-//        String qs = join(Collections2.transform(params.entrySet(), new MapEntryToQueryStringPair()), "&");
+            .map(s -> URLEncoder.encode(s.getKey(), StandardCharsets.UTF_8) + "=" + URLEncoder.encode(s.getValue(), StandardCharsets.UTF_8))
+            .collect(Collectors.joining("&"));
         ExtractHeader location = client.post(url + "buildWithParameters?" + qs,null, ExtractHeader.class, fileParams, crumbFlag);
         return new QueueReference(location.getLocation());
     }