Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(input)!: Cleanup to prepare for trait merger #105

Merged
merged 19 commits into from
Jan 30, 2023
Merged

fix(input)!: Cleanup to prepare for trait merger #105

merged 19 commits into from
Jan 30, 2023

Conversation

epage
Copy link
Collaborator

@epage epage commented Jan 30, 2023 •
edited
Loading

Trying to separate this from the trait merger that mirrors rust-bakery/nom#1612 so its easier to talk about both.

In general

  • Clarifies what types are input types
    • This highlighted that ContainsToken (formerly FindTokens) is actually a token type
    • There are still some types being treated as input that aren't properly input
  • Clarifies terminology
  • Makes generic parameters more consistent

@epage
fix(input)!: Converge on Offset, dropping Position
d8efd94
@epage
fix(input)!: Clarify direction offset_to goes
996aa76 
This is something that I've messed up with the API.
@epage
refactor: Normalize generic parameters
9194d76 
Mostly to move off of `Input` to make things unambiguous.
@epage
fix(input)!: Consolidate on offset
9db3e58 
winnow-rs#93 is an example of the type of bugs from inconsistent terminology

BREAKING CHANGE:
- `InputIter::Iter` as `InputIter::IterOffsets`
- `InputIter::iter_indices` as `InputIter::iter_offsets`
- `InputIter::position` as `InputIter::offset_for`
- `InputIter::slice_index` as `InputIter::offset_at`
@epage
fix(input)!: Drop apparently unused input types
766a343
@epage
style(input): Put emphasis on core types
70931df
@epage
docs(input): Use consistent "offset" term for FindSubstring
7e1d299
@epage
fix(input)!: Clarify FindTokens is actually a ContainsToken
a249765
@epage
style(input): Group traits that will be replaced
d3ceffc
@epage
style(input): Better group token traits
dcc2d08
@epage
style(input): Be consistent in input generic parameter
2c889e7
@coveralls
Copy link

coveralls commented Jan 30, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4048230646

  • 368 of 775 (47.48%) changed or added relevant lines in 14 files are covered.
  • 3 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+0.8%) to 56.841%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/branch/mod.rs 0 1 0.0%
src/combinator/mod.rs 8 10 80.0%
src/character/complete.rs 17 21 80.95%
src/number/complete.rs 6 12 50.0%
src/character/streaming.rs 12 19 63.16%
src/number/streaming.rs 6 13 46.15%
src/bytes/complete.rs 37 46 80.43%
src/bytes/streaming.rs 25 43 58.14%
src/input.rs 230 583 39.45%
Files with Coverage Reduction New Missed Lines %
src/branch/mod.rs 1 84.21%
src/bytes/complete.rs 1 69.52%
src/bytes/streaming.rs 1 56.45%
Totals Coverage Status
Change from base Build 4028711102: 0.8%
Covered Lines: 1749
Relevant Lines: 3077
💛 - Coveralls

@epage epage merged commit 74948e5 into winnow-rs:main Jan 30, 2023
@epage epage deleted the input2 branch January 30, 2023 21:26
@coveralls
Copy link

coveralls commented Oct 7, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 4047093315

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 344 of 735 (46.8%) changed or added relevant lines in 14 files are covered.
  • 60 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.7%) to 56.694%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/branch/mod.rs 0 1 0.0%
src/combinator/mod.rs 8 10 80.0%
src/character/complete.rs 15 21 71.43%
src/number/complete.rs 6 12 50.0%
src/character/streaming.rs 12 19 63.16%
src/number/streaming.rs 6 13 46.15%
src/bytes/complete.rs 37 46 80.43%
src/bytes/streaming.rs 25 43 58.14%
src/input.rs 208 543 38.31%
Files with Coverage Reduction New Missed Lines %
src/branch/mod.rs 1 84.21%
src/bytes/complete.rs 1 69.52%
src/bytes/streaming.rs 1 56.45%
src/bits/mod.rs 2 71.79%
src/bytes/mod.rs 5 87.3%
src/input.rs 50 38.6%
Totals Coverage Status
Change from base Build 4028711102: 0.7%
Covered Lines: 1749
Relevant Lines: 3085
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@epage @coveralls