Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prefer Into over From in bounds #110

Merged
merged 1 commit into from
Feb 1, 2023
Merged

fix: Prefer Into over From in bounds #110

merged 1 commit into from
Feb 1, 2023

Conversation

epage
Copy link
Collaborator

@epage epage commented Feb 1, 2023

Unsure how to handle O: From<u8> type bounds.

Inspired by rust-bakery/nom#1460

Unsure how to handle `O: From<u8>` type bounds.

Inspired by rust-bakery/nom#1460
@coveralls
Copy link

coveralls commented Feb 1, 2023

Pull Request Test Coverage Report for Build 4068731687

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.1%) to 58.077%

Files with Coverage Reduction New Missed Lines %
src/combinator/mod.rs 1 58.2%
Totals Coverage Status
Change from base Build 4068638160: 0.1%
Covered Lines: 1679
Relevant Lines: 2891

💛 - Coveralls

@epage epage merged commit 5de5f7b into winnow-rs:main Feb 1, 2023
@epage epage deleted the into branch February 1, 2023 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants