Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(parser): Switch literal impl's from one_of to literal #464

Merged
merged 2 commits into from
Feb 7, 2024
Merged

fix(parser): Switch literal impl's from one_of to literal #464

merged 2 commits into from
Feb 7, 2024

Commits on Feb 7, 2024

  1. fix(parser)!: Switch char from one_of to literal 

    Originally, this was going to be done for performance reasons but when
comparing this to the previous commit, `tag(char)` / `char` slowed down
dramatically in the `next_slice` benchmark.

However, `json` benchmark was unchanged.  This also (slightly)
simplifies traces, is more direct in what it says, and does still speed
things up for UTF-8-exclusive `char`s, so going forward with it.

Fixes winnow-rs#418

BREAKING CHANGE: `char` parers now always return `char` as the output
and now require `I: Compare<char>`
    @epage
    epage committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    925fba7 View commit details
    Browse the repository at this point in the history

  2. fix(parser)!: Switch u8 from one_of to literal 

    Based on how `char` went, I figured we will likely see similar.

Fixes winnow-rs#427

BREAKING CHANGE: `u8` parers now  require `I: Compare<u8>`
    @epage
    epage committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    502a36f View commit details
    Browse the repository at this point in the history