Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser)!: Split Parser::into into Parser::output_into and Parser::err_into #48

Merged
merged 2 commits into from
Dec 21, 2022

Conversation

epage
Copy link
Collaborator

@epage epage commented Dec 21, 2022

Bringing in the Parser trait prevents using Into::into and
Parser::into as postfix. One way to fix this is to rename
Parser::into but the only idea I had for doing so was to split it
which I think makes more sense.

…:err_into

Bringing in the `Parser` trait prevents using `Into::into` and
`Parser::into` as postfix.  One way to fix this is to rename
`Parser::into` but the only idea I had for doing so was to split it
which I think makes more sense.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 3750289026

  • 3 of 11 (27.27%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 57.86%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser.rs 2 3 66.67%
src/combinator/mod.rs 1 8 12.5%
Files with Coverage Reduction New Missed Lines %
src/character/complete.rs 1 78.87%
Totals Coverage Status
Change from base Build 3733108228: -0.2%
Covered Lines: 1833
Relevant Lines: 3168

💛 - Coveralls

@epage epage merged commit ee7cc16 into main Dec 21, 2022
@epage epage deleted the into branch December 21, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants