Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: let scope only be affected when check FDs #12

Merged
merged 3 commits into from
Mar 17, 2022

Conversation

winoros
Copy link
Owner

@winoros winoros commented Mar 15, 2022

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to update the tidb-ansible repository
  • Need to be included in the release note

winoros added a commit that referenced this pull request Mar 15, 2022
@AilinKid
Copy link
Collaborator

got, the new built equal condition for #column5 (projected from correlated) and #column4 (extracted from correlated's column) can't resolve it's index in physical optimization, cause this EQ func can't find #column4 from it's both child's schema

@AilinKid AilinKid closed this Mar 17, 2022
@AilinKid AilinKid reopened this Mar 17, 2022
Copy link
Collaborator

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AilinKid AilinKid merged commit 030a6ba into functional-dependency Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants