Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buildtools signing #2193

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Buildtools signing #2193

wants to merge 10 commits into from

Conversation

dmex
Copy link
Member

@dmex dmex commented Sep 11, 2024

No description provided.

@dmex dmex requested a review from jxy-s as a code owner September 11, 2024 07:16
@dmex dmex mentioned this pull request Sep 15, 2024
Closed
@dmex dmex self-assigned this Sep 28, 2024
@dmex dmex linked an issue Sep 28, 2024 that may be closed by this pull request
Don't builded #2207
Closed
@dmex dmex removed a link to an issue Sep 28, 2024
Don't builded #2207
Closed
@dmex dmex force-pushed the master branch 2 times, most recently from b69e891 to 975984f Compare October 18, 2024 22:28
@ge0rdi
Copy link
Contributor

ge0rdi commented Nov 1, 2024

@dmex
Wondering when this PR could be merged.

It contains fix for SourceLink (among other things), that would be nice to have working.
Maybe you can merge at least that fix? So that future PDBs will contain proper SourceLink information.

@jxy-s
Copy link
Member

jxy-s commented Nov 2, 2024 •
edited
Loading

@dmex Wondering when this PR could be merged.

It contains fix for SourceLink (among other things), that would be nice to have working. Maybe you can merge at least that fix? So that future PDBs will contain proper SourceLink information.

I think this branch needs more testing? If we want the SourceLink work we should just pull that forward on its own.

@ge0rdi
Copy link
Contributor

ge0rdi commented Nov 2, 2024

If we want the SourceLink work we should just pull that forward on its own.

That would be really cool.
I have created fix some time ago (#2203), but it was closed because this PR contains the fix as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jxy-s jxy-s Awaiting requested review from jxy-s jxy-s is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@dmex dmex

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmex @ge0rdi @jxy-s