fix for winston.config.syslog.levels which are not in the right priority order for winston #52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
winston
default logging priority order is ascending goes from lowest 0 (silly) to highest 5 (error)but syslog priority order is descending from lowest 7 (debug) to highest 0 (emerg)
this means that when setting a log level for
winston
when using syslogyou will actually log below that level instead of above it
so setting logger.level='info' (which is the default)
will actually log debug and info but will not log notice warning and so on.
I'm not sure if this is the right place for this fix
but I opend an issue for
winston
a few days ago and didn't get any attentionsince the bad config mostly affects
winston-syslog
users I thought it can be fixed withinwinston-syslog
a better fix might be to have the levels conf under Syslog namespace and not requiring winston config at all but that will require changing the docs