Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc is missing humanReadableUnhandledException #549

Closed
tupadr3 opened this issue Feb 8, 2015 · 5 comments
Closed

Doc is missing humanReadableUnhandledException #549

tupadr3 opened this issue Feb 8, 2015 · 5 comments
Assignees
@pose
Labels
Docs Applies to Winston's documentation

Comments

@tupadr3
Copy link

tupadr3 commented Feb 8, 2015

The option to set the "humanReadableUnhandledException" is missing from the doc. I took me a while the find out that this feature was implemented a few days ago.
@tupadr3 tupadr3 changed the title Doc is missing Doc is missing humanReadableUnhandledException Feb 8, 2015
@pose pose self-assigned this Feb 8, 2015
@pose pose added the Docs Applies to Winston's documentation label Feb 8, 2015
@jcrugzz
Copy link
Contributor

jcrugzz commented Feb 16, 2015

@tupadr3 would happily take a PR fixing this :).

@foxx
Copy link
Contributor

foxx commented Mar 30, 2015

PR sent, however I would argue that the primary use case for console transport is local dev/debugging, and therefore this flag should be true by default. Thoughts?

@jcrugzz
Copy link
Contributor

jcrugzz commented Mar 30, 2015

@foxx the plan is to make it the default behavior in 1.0.0. Since it breaks backward compatibility it requires a major version bump

@jcrugzz
Copy link
Contributor

jcrugzz commented Mar 30, 2015

@foxx I also don't see your PR in the list so make sure you submit it so i can pull it in! :)

@foxx
Copy link
Contributor

foxx commented Mar 30, 2015

Oops my bad, it's #592. Sounds great, thanks :)

indexzero added a commit that referenced this issue Mar 30, 2015
@indexzero
Merge pull request #592 from foxx/patch-1
412ed20 
fixes #549
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pose pose

Labels
Docs Applies to Winston's documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pose @jcrugzz @foxx @tupadr3