Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance message for logs with no transports #2114 #2139

Merged
merged 2 commits into from
Jun 21, 2022
Merged

enhance message for logs with no transports #2114 #2139

merged 2 commits into from
Jun 21, 2022

Conversation

zizifn
Copy link
Contributor

@zizifn zizifn commented May 26, 2022

If the user uses logger with no transports, Winston will only console certain logs with a warning.
image

As we add documentation for the point memory issue in PR #2138. Today, when I discuss this with team member cc @superobin, maybe it's better to enhance the existing no transports warning message.

Message in this PR:

image

Test code :

const w = require('winston')
// const w = require('./lib/winston')

setInterval(() => {
    w.error('test'.repeat(100))
}, 10)

@zizifn
Copy link
Contributor Author

zizifn commented May 26, 2022

@wbt Could you take look at this PR? Sorry for the back and forth for issue #2114, If you think change code maybe exaggerate this issue, I'm fine for close PR.

@zizifn zizifn marked this pull request as ready for review May 26, 2022 12:26
lib/winston/logger.js Outdated Show resolved Hide resolved
@wbt wbt merged commit f707f33 into winstonjs:master Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants