Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the stringify replacer option to the HTTP transport #2155

Merged
merged 1 commit into from
Jun 23, 2022

Conversation

domiins
Copy link
Contributor

@domiins domiins commented Jun 23, 2022

Support custom stringify replacer when sending logs via HTTP transport.

Usage of the format.json with the custom replacer does not work with
HTTP transport since the message symlink (which is mutated) is not sent
in the request.

Work done:

  • Add the replacer property into the type of the HttpTransportOptions
  • Use the replacer from the options optionally in the jsonStringify of HTTP transport

Support custom stringify replacer when sending logs via HTTP transport.

Usage of the `format.json` with the custom replacer does not work with
HTTP transport since the message symlink (which is mutated) is not sent
in the request.
@wbt
Copy link
Contributor

wbt commented Jun 23, 2022

Thanks for your contribution!

@wbt wbt merged commit 355650e into winstonjs:master Jun 23, 2022
@domiins domiins deleted the feature/http-transfer-replacer branch June 23, 2022 14:42
@wbt
Copy link
Contributor

wbt commented Jun 23, 2022

Out in 3.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants