[WIP] Replacement warnings

modules/system/classes/PluginManager.php

@@ -668,6 +668,16 @@ protected function populateDisabledPluginsFromDb()
         }
     }
 
+    /**
+     * Returns the plugin replacements defined in $this->replacementMap
+     *
+     * @return array
+     */
+    public function getReplacementMap()
+    {
+        return $this->replacementMap;
+    }
+
     /**
      * Evaluates and initializes the plugin replacements defined in $this->replacementMap
      *

modules/system/classes/UpdateManager.php

@@ -184,6 +184,13 @@ public function update()
             }
         }
 
+        // Set replacement warning messages
+        foreach ($this->pluginManager->getReplacementMap() as $alias => $plugin) {
+            $this->addMessage($plugin, Lang::get('system::lang.updates.update_warnings_plugin_replace_cli', [
+                    'alias' => '<info>' . $alias . '</info>'
+            ]));
+        }
+
         // Print messages returned by migrations / seeders
         $this->printMessages();
 

modules/system/controllers/Updates.php

@@ -244,6 +244,15 @@ protected function getWarnings()
             }
         }
 
+        $replacementMap = PluginManager::instance()->getReplacementMap();
+
+        foreach ($replacementMap as $alias => $plugin) {
+            $warnings[] = Lang::get('system::lang.updates.update_warnings_plugin_replace', [
+                'plugin' => '<strong>' . $plugin . '</strong>',
+                'alias' => '<strong>' . $alias . '</strong>'
+            ]);
+        }
+
         return $warnings;
     }
 

modules/system/lang/en/lang.php

@@ -336,6 +336,8 @@
         'core_set_build' => 'Setting build number',
         'update_warnings_title' => 'Some issues have been detected and require attention:',
         'update_warnings_plugin_missing' => 'The :parent_code plugin requires :code to be installed before it will work',
+        'update_warnings_plugin_replace' => 'The :plugin plugin replaces :alias, please remove :alias to ensure the are no conflicts',
+        'update_warnings_plugin_replace_cli' => 'This plugin replaces :alias, please remove :alias to ensure the are no conflicts',
         'changelog' => 'Changelog',
         'changelog_view_details' => 'View details',
         'plugins' => 'Plugins',