[FIX] Plugin warnings only shown for active replacements #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
LukeTowers
added a commit
that referenced
this pull request
May 14, 2021
* develop: (45 commits) Revert "Add class alias registration method to plugins (#152)" (#176) Add class alias registration method to plugins (#152) Improved Latvian translation (#142) Fixing styles for custom checkbox (#140) ImageResizer should support uppercase file extensions (#135) Improved Italian Translations (#134) Improved Latvian translation (#128) Update lang.php Only show plugin warnings for active replacements (#122) Fix unit tests Ensure route attributes from plugins are properly loaded Revert "Support ReportContainers that are aliases of real ReportContainers" Ensure all plugins are uninstalled when the system is uninstalled (#114) Add history of replacement plugins to the system_plugin_history table (#115) Warn when replaced plugins are still present (#109) Added plugin registration after loading (#113) Fixed issue with taglist when not readOnly but an array value Improve handling for null being passed to the ImageResizer Add discord badge Support ReportContainers that are aliases of real ReportContainers ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the
PluginManager'sreplacementMapisn't cleared when an original plugin is not installed the warnings were still being shown.This patch adds support for tracking active replacements within the
PluginManagerand uses that data to check if the original plugin has been removed before displaying warnings.Fixes #123