Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NestedForm bugs #14

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

NestedForm bugs #14

wants to merge 4 commits into from

Conversation

AIC-BV
Copy link
Contributor

@AIC-BV AIC-BV commented Dec 1, 2022

PR covers and demonstrates three issues I currently have, when reproducing I noticed it all has to do with NestedForm:

  1. Translations are going too deep wn-translate-plugin#44
  2. Repeater reorder not working in a repeater with nestedform winter#715
  3. Trigger events field with ^ parent selector does not work (nestedform) winter#716
  1. NestedForm is being translated in jsonable field, and it conflicts with same codes outside of the NestedForm
  2. Reorder is not working in the NestedForm
  3. Triggers not working with NestedForm

@bennothommo
Copy link
Member

@AIC-BV what is the reasoning or particular issue that you're demonstrating with this PR?

@mjauvin
Copy link
Member

mjauvin commented Dec 2, 2022

@bennothommo Winter Translate issue #44 as stated in PR description

@bennothommo
Copy link
Member

bennothommo commented Dec 2, 2022

@mjauvin sorry, I missed the commit (although it was a bit vague to me until you explained it).

Nevertheless, I would prefer if we have some form of description for this change, for historical clarity. @AIC-BV could you add some detail and change the title of PR?

@AIC-BV AIC-BV changed the title Aic issues NestedForm issues Dec 5, 2022
@AIC-BV
Copy link
Contributor Author

AIC-BV commented Dec 5, 2022

I added a description and changed the title

@AIC-BV AIC-BV changed the title NestedForm issues NestedForm bugs Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants