Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin icons #50

Merged
merged 3 commits into from
Mar 17, 2024
Merged

Update plugin icons #50

merged 3 commits into from
Mar 17, 2024

Conversation

WebVPF
Copy link
Contributor

@WebVPF WebVPF commented Mar 11, 2024

sideMenu

Before:
before-usersmenu

After:
after-2

Links to icons in the catalog:

Settings menu:

Before:
before-settingsmenu

After:
after-settingsmenu

Link: https://fontawesome.com/icons/user-gear?f=classic&s=solid

@LukeTowers
Copy link
Member

@bennothommo any idea what's wrong with the tests on the repo right now?

Restore the icon for the Users menu item in the side menu
@WebVPF
Copy link
Contributor Author

WebVPF commented Mar 12, 2024

I updated the screenshot with the result.


I would also like to suggest changes to the rest of the main menu icons.

October Style:
menu-october-style

Winter Style:
menu-winter-style-2

No plugins:
menu-noplugins-2

If the new style suits, I can update all the SVG icons.

The color #3498db is applied to the icons. It is taken from the logo (snowflake).

@LukeTowers
Copy link
Member

@WebVPF I really like those! I don't think we should change the dashboard icon to the logo though, end users don't necessarily know or care that their site or platform is running Winter so it's less obvious what exactly that icon means to them. The CMS icon change is also similar in that the original icon was more clear as to what exactly it is (although I do like that new icon, just not sure what it works best for 😄)

@WebVPF
Copy link
Contributor Author

WebVPF commented Mar 15, 2024

@LukeTowers I agree.
Do you have any remarks on this pull request?

@LukeTowers LukeTowers merged commit 519500c into wintercms:main Mar 17, 2024
0 of 3 checks passed
@LukeTowers
Copy link
Member

Nope, looks great @WebVPF! Thanks!

@WebVPF WebVPF deleted the icons branch March 17, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants