Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added the ablity to select target architecture for linux builds #8294

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

e-lisa
Copy link

@e-lisa e-lisa commented Oct 22, 2024


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Cannot select build architecture for Linux builds.

Causes (Optional)

Build script does not allow for setting of the build architecture, it is hard-coded to "x64"

Solutions

Allow architecture to be specified at the command-line via a new variable $ARCH. Possible values for ARCH are documented here: https://www.electron.build/electron-builder.enumeration.arch

enviormental variable `$ARCH`. Defaults to if ARCH not provided`x64`.

Updated the README to reflect new build options.
@e-lisa e-lisa changed the title Feat: Added the ablity to select target architechture for linux builds feat: Added the ablity to select target architechture for linux builds Oct 22, 2024
Copy link

sonarcloud bot commented Oct 22, 2024

@e-lisa e-lisa changed the title feat: Added the ablity to select target architechture for linux builds feat: Added the ablity to select target architecture for linux builds Oct 22, 2024
Copy link
Contributor

@V-Gira V-Gira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Thank you for taking the initiative to raise a PR @e-lisa , much appreciated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants