[sft] Add srv-announcer role to the SFT deployment automation #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansible/provision-sft.yml
Outdated
Comment on lines
10
to
14
| roles: | ||
| - role: sft-server | ||
| tasks: | ||
| - import_role: | ||
| name: 'sft-server' | ||
| - import_role: | ||
| name: 'srv-announcer' |
There was a problem hiding this comment.
Is there a difference between listing roles and importing them?
There was a problem hiding this comment.
Technically speaking, no - I remembered it differently. I thought, roles: would load them dynamically, but I was wrong. It's loading them statically. Writing it this way, it makes it more obvious, though. Anyway, I'll change it back.
lucendio
force-pushed
the
add-srv-announcer-role
branch
3 times, most recently
from
88a34b8
to
1b2f1ac
Compare
akshaymankar
approved these changes
Sep 25, 2020
ansible/requirements.yml
Outdated
| version: "20d4f19685777ed3f4d11fa100bdbdd4a7e2ce1f" # master (2020-09-16) | ||
| version: "49474b01e7e5dba3eb7e67376f8598190fd4c6cb" # move-deps-list (2020-09-24) |
There was a problem hiding this comment.
This needs to be updated to point to latest master.
Update variables in the inventory template to match the latest version of the role and pin to the corresponding commit.
lucendio
force-pushed
the
add-srv-announcer-role
branch
from
1b2f1ac
to
be30444
Compare
lucendio
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update variables in the inventory template to match the latest version of
the role and pin to the corresponding commit.
Moved from 'roles' directive in the playbook to 'import_role' in order to
import roles instead of including them.