Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pending invitations by email lookup #1168

Merged
merged 3 commits into from
Jul 16, 2020
Merged

Conversation

jschaul
Copy link
Member

@jschaul jschaul commented Jul 13, 2020

Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good otherwise!

services/brig/brig.cabal Outdated Show resolved Hide resolved
services/brig/schema/src/V60.hs Outdated Show resolved Hide resolved
services/brig/schema/src/V60.hs Outdated Show resolved Hide resolved
services/brig/src/Brig/Team/API.hs Outdated Show resolved Hide resolved
services/brig/src/Brig/Team/API.hs Outdated Show resolved Hide resolved
services/brig/src/Brig/Team/DB.hs Outdated Show resolved Hide resolved
services/brig/src/Brig/Team/DB.hs Outdated Show resolved Hide resolved
@jschaul jschaul force-pushed the jschaul/pending-invitations branch 2 times, most recently from a1ab0fa to afc485a Compare July 14, 2020 16:33
@jschaul jschaul changed the title [WIP] pending invitations Pending invitations by email lookup Jul 14, 2020
@jschaul jschaul marked this pull request as ready for review July 14, 2020 16:49
Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

services/brig/src/Brig/Team/API.hs Show resolved Hide resolved
services/brig/test/integration/API/Team.hs Show resolved Hide resolved
jschaul added a commit to wireapp/wire-server-deploy that referenced this pull request Jul 15, 2020
add nginz unauthenticated endpoint for pending invitation request
See also zinfra/backend-issues#1489
and related PR wireapp/wire-server#1168
jschaul added a commit to wireapp/wire-server-deploy that referenced this pull request Jul 15, 2020
add nginz unauthenticated endpoint for pending invitation request
See also zinfra/backend-issues#1489
and related PR wireapp/wire-server#1168
@jschaul jschaul force-pushed the jschaul/pending-invitations branch 2 times, most recently from eafa122 to 302a2c1 Compare July 15, 2020 13:46
@jschaul
Copy link
Member Author

jschaul commented Jul 15, 2020

This PR now only depends on

Context: zinfra/backend-issues#1489

"Allow people to know if there is a pending invitation for a given email".
Add nginz test for that public endpoint,
requires wireapp/wire-server-deploy#317
for CI tests to pass.
@jschaul jschaul force-pushed the jschaul/pending-invitations branch from 99e726d to 30f5122 Compare July 16, 2020 10:16
@jschaul
Copy link
Member Author

jschaul commented Jul 16, 2020

CI failure is unrelated to this PR (tracked in zinfra/backend-issues#1600 ), all tests pass locally, and all relevant tests pass on CI.

@jschaul jschaul merged commit 0e5bf97 into develop Jul 16, 2020
@jschaul jschaul deleted the jschaul/pending-invitations branch July 16, 2020 12:03
@fisx fisx mentioned this pull request Jul 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants