[skip ci] Upgrade GHC to 8.8.4 #1204
Conversation
Not sure why, but this convinces GHC to not inline things very aggressively.
akshaymankar
changed the title
|
Special pipeline here: https://bridge-ie-concourse.zinfra.io/teams/main/pipelines/wire-server-ghc88. |
There was a problem hiding this comment.
Generally looks good.
Two things:
- can the dependencies be based on merged commits, rather than hanging branches that may disappear by accident?
Special pipeline here: https://bridge-ie-concourse.zinfra.io/teams/main/pipelines/wire-server-ghc88.
- can the ubuntu-based Docker image also be tested with ghc-8.8? The pipeline seems to include an ubuntu image as well; however I cannot find the pipeline code that was used to create this pipeline anywhere. Please link.
stack.yaml
Outdated
| @@ -64,7 +64,7 @@ extra-deps: | |||
| # a version > 1.0.0 of wai-middleware-prometheus is available | |||
| # (required: https://github.com/fimad/prometheus-haskell/pull/45) | |||
| - git: https://github.com/wireapp/saml2-web-sso | |||
| commit: 687d9ac8ac2994aff8436189c6ecce29faad8500 # master (May 18, 2020) | |||
| commit: be04baaffb92ff64d8e1d9f400ec45849d754faf # akshaymankar/ghc-8.8 (Aug 21, 2020) | |||
There was a problem hiding this comment.
The various forks should have a reference to a stable branch, not a PR branch which will be deleted after merging the PR. Perhaps before merging this PR; merge the upstream ones and use a stable branch commit identifier?
There was a problem hiding this comment.
This one is the only one we control. I created PR here: wireapp/saml2-web-sso#66
No other branches will get deleted on merge, I have set the option to not delete it in Gitlab. For github forks we don't need to worry as github only deletes branches in the same repo.
I suspect some of the upstream maintainers aren't maintaining the packages very actively, so it might take very long. So, I think it is fine to refer to these packages in their forks.
Fixes https://github.com/zinfra/backend-issues/issues/1622