Simplify user feature logic #4178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: product-roadmap
zebot
added
the
ok-to-test
pcapriotti
force-pushed
the
pcapriotti/one-to-one-sft
branch
from
84e0e0a
to
8eda399
Compare
pcapriotti
force-pushed
the
pcapriotti/user-features
branch
from
bc45d30
to
5030c22
Compare
pcapriotti
force-pushed
the
pcapriotti/user-features
branch
from
5030c22
to
0d7768d
Compare
MangoIV
force-pushed
the
pcapriotti/user-features
branch
from
0d7768d
to
7c5ee3c
Compare
MangoIV
approved these changes
Aug 7, 2024
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a refactoring of the user feature lookup logic. It removes a redundant team lookup and a gratuitous CPS.
Followup to #4164.
https://wearezeta.atlassian.net/browse/WPB-10323
Checklist
changelog.d