Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WPB-8887] wire-subsystems: implement the GetBy* account queries, includes InvitationCodeStore. #4218

Merged
merged 102 commits into from
Sep 12, 2024
Merged

[WPB-8887] wire-subsystems: implement the GetBy* account queries, includes InvitationCodeStore. #4218

merged 102 commits into from
Sep 12, 2024

Conversation

MangoIV
Copy link
Collaborator

@MangoIV MangoIV commented Aug 19, 2024 •
edited by elland
Loading

https://wearezeta.atlassian.net/browse/WPB-8887

  • new Effect operation GetAccountBy in UserSubsystem
  • new record GetBy
  • new stores ActivationCodeStore and InvitationCodeStore
  • new sql quasiquoter in cassandra-util
  • some more Ord instances derived
  • new function tSplit for the use with ViewPatterns
  • drive-by cleaning up invitation accessors

The remaining part of the ticket will be addressed in a separate PR.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@echoes-hq echoes-hq bot added the echoes: technical-roadmap/throughput Changes intended at preserving our ability to evolve the software safely and effectively label Aug 19, 2024
@MangoIV MangoIV changed the title [WPB-8887] initial impl for GetBy* account queries as Effect and interpreter [WPB-8887] wire-subsystems: implement the GetBy* account queries Aug 19, 2024
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Aug 19, 2024
@mdimjasevic mdimjasevic self-requested a review August 21, 2024 09:58
@elland elland force-pushed the mangoiv/wpb-8887 branch 3 times, most recently from 13c7eaf to 6fbb7ec Compare August 27, 2024 14:23
@elland elland marked this pull request as ready for review August 29, 2024 08:06
fisx
fisx reviewed Aug 29, 2024
View reviewed changes
libs/wire-subsystems/src/Wire/InvitationCodeStore.hs Show resolved Hide resolved
changelog.d/5-internal/wpb-8887 Outdated Show resolved Hide resolved
libs/wire-subsystems/src/Wire/InvitationCodeStore/Cassandra.hs Outdated Show resolved Hide resolved
libs/wire-subsystems/src/Wire/InvitationCodeStore/Cassandra.hs Outdated Show resolved Hide resolved
libs/types-common/src/Wire/Timeout.hs Outdated Show resolved Hide resolved
libs/types-common/src/Wire/Timeout.hs Outdated Show resolved Hide resolved
fisx
fisx reviewed Aug 29, 2024
View reviewed changes
tools/stern/stern.cabal Show resolved Hide resolved
libs/types-common/src/Wire/Timeout.hs Outdated Show resolved Hide resolved
libs/wire-subsystems/src/Wire/UserSubsystem/Interpreter.hs Outdated Show resolved Hide resolved
libs/wire-subsystems/src/Wire/UserSubsystem/Interpreter.hs Outdated Show resolved Hide resolved
libs/wire-subsystems/test/unit/Wire/MockInterpreters/InvitationCodeStore.hs Outdated Show resolved Hide resolved
services/brig/src/Brig/Team/API.hs Show resolved Hide resolved
services/brig/src/Brig/Team/API.hs Show resolved Hide resolved
services/brig/src/Brig/Team/API.hs Outdated Show resolved Hide resolved
services/brig/src/Brig/Team/API.hs Outdated Show resolved Hide resolved
services/brig/src/Brig/Team/API.hs Show resolved Hide resolved
@fisx
Copy link
Contributor

fisx commented Sep 2, 2024

didn't we decide to leave account stuff out of this PR, and make it only about Invitations?

elland
elland approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@elland elland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@fisx
Copy link
Contributor

fisx commented Sep 12, 2024

this took wayyyy too long, but not wayyyyyyyy to long :) i think the result is quite valuable.

@fisx fisx mentioned this pull request Sep 12, 2024
Merged
5 tasks
@fisx fisx merged commit f1bc7b9 into develop Sep 12, 2024
10 checks passed
@fisx fisx deleted the mangoiv/wpb-8887 branch September 12, 2024 16:00
@zebot zebot mentioned this pull request Oct 9, 2024
Closed
This was referenced Oct 23, 2024
Closed
Closed
@zebot zebot mentioned this pull request Oct 30, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elland elland elland approved these changes

@fisx fisx fisx approved these changes

@mdimjasevic mdimjasevic Awaiting requested review from mdimjasevic

Assignees
No one assigned
Labels
echoes: technical-roadmap/throughput Changes intended at preserving our ability to evolve the software safely and effectively ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@MangoIV @fisx @elland @zebot @mdimjasevic