-
Notifications
You must be signed in to change notification settings - Fork 324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WPB-10772] Make it impossible for a user under legalhold to join an MLS conversation #4242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MangoIV
changed the title
Wpb 10772
[WPB-10772] make it impossible for a user under legalhold to join an MLS conversation
Sep 16, 2024
zebot
added
the
ok-to-test
Approved for running tests in CI, overrides not-ok-to-test if both labels exist
label
Sep 16, 2024
echoes-hq
bot
added
the
echoes/initiative: federation-wire-cloud
Activate Federation with MLS on Wire Cloud
label
Sep 16, 2024
- new client error which returns 409 if someone (client or federating backend) tries to claim a keypackage of a user under legalhold (including pending) - add Fail effect to Brig and interpret to IO Error (server error 500)
- if a user doens't claim keypackages (because they create the group by themselves) the local backend checks whether that user is legalholded and rejects the commit in that case - also adds some utilities (e.g. pattern synonyms fo Local and Remote) and propagates the Fail constraint
-- ---------
-- WPB-10783
-- ---------
testMLSThenLegalhold :: (HasCallStack) => App ()
testMLSThenLegalhold = do
-- scenario 1:
-- if charlie is in any MLS conversation, he cannot approve to be put under legalhold
(charlie, tid, []) <- createTeam OwnDomain 1
[charlie1] <- traverse (createMLSClient def) [charlie]
void $ createNewGroup charlie1
void $ createAddCommit charlie1 [charlie] >>= sendAndConsumeCommitBundle
legalholdWhitelistTeam tid charlie >>= assertStatus 200
withMockServer def lhMockApp \lhDomAndPort _chan -> do
postLegalHoldSettings tid charlie (mkLegalHoldSettings lhDomAndPort) >>= assertStatus 201
requestLegalHoldDevice tid charlie charlie >>= assertSuccess
approveLegalHoldDevice tid (charlie %. "qualified_id") defPassword
`bindResponse` assertLabel 409 "mls-legalhold-not-allowed" |
pcapriotti
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
- introduce new type RelativeTo - remove leftovers - adjust changelog
akshaymankar
changed the title
[WPB-10772] make it impossible for a user under legalhold to join an MLS conversation
[WPB-10772] Make it impossible for a user under legalhold to join an MLS conversation
Sep 18, 2024
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
echoes/initiative: federation-wire-cloud
Activate Federation with MLS on Wire Cloud
ok-to-test
Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two things to do:
Checklist
changelog.d