Fix feature flag defaults #4265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since an empty download location is now disallowed, we use the empty string as a value that signifies "no download location" in the database.
echoes-hq
bot
added
echoes: unplanned
zebot
added
the
ok-to-test
pcapriotti
force-pushed
the
flag-defaults
branch
from
cd02695
to
f18bb78
Compare
pcapriotti
force-pushed
the
flag-defaults
branch
2 times, most recently
from
deae2a1
to
1c9418b
Compare
pcapriotti
force-pushed
the
flag-defaults
branch
from
1c9418b
to
b98ac55
Compare
pcapriotti
force-pushed
the
flag-defaults
branch
from
f1ab0b5
to
e77dd7d
Compare
fisx
approved these changes
Sep 30, 2024
pcapriotti
force-pushed
the
flag-defaults
branch
from
a24f274
to
33c355e
Compare
Co-authored-by: Matthias Fischmann <[email protected]>
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the way the
DbFeatureis computed formlsMigrationandenforceFileDownloadLocation. Before, we were using anullcassandra value to represent both the absence of configuration and the presence of aNothingvalue. The consequence was that the default would be accidentally overwritten by theNothingvalue in some cases.The fix is to use an explicit "null" value to represent
Nothing. For dates, we use the POSIX timestamp origin. For the download location, we use an empty string.Also, this PR contains a refactoring and reorganization of the test module for feature flags. It has been split into several modules, one per feature, and the various utilities have been simplified and made more uniform across features.
https://wearezeta.atlassian.net/browse/WPB-11100
Checklist
changelog.d