[WPB-10314] validate swagger: add swagger linter to integration tests (so it'll run in CI). #4302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: unplanned
zebot
added
the
ok-to-test
fisx
force-pushed
the
WPB-10314-validate-swagger-2
branch
from
462ac5f
to
3983741
Compare
fisx
changed the title
|
Didn't we say the plan was to write a tool that produces the swagger JSON at linting time? Adding this to integration tests feels wrong. |
pcapriotti
force-pushed
the
WPB-10314-validate-swagger-2
branch
from
3983741
to
93f82da
Compare
fisx
force-pushed
the
WPB-10314-validate-swagger-2
branch
from
bc00241
to
e01dde3
Compare
pcapriotti
force-pushed
the
WPB-10314-validate-swagger-2
branch
2 times, most recently
from
762a241
to
7d2735e
Compare
fisx
force-pushed
the
WPB-10314-validate-swagger-2
branch
from
fefd4ad
to
49b5547
Compare
pcapriotti
force-pushed
the
WPB-10314-validate-swagger-2
branch
from
d6c7109
to
88ea3c9
Compare
2 tasks
This should avoid temporary failures during deployment.
fisx
commented
Oct 25, 2024
There was a problem hiding this comment.
LGTM! @pcapriotti could you please approve and merge? i created this PR.
Co-authored-by: Matthias Fischmann <[email protected]>
|
This was actually still missing fixes for galley's internal API swagger. I wasn't expecting you to merge. It's fine, I'll make a new PR. |
2 tasks
fisx
added a commit
that referenced
this pull request
Oct 30, 2024
fisx
added a commit
that referenced
this pull request
Oct 30, 2024
fisx
added a commit
that referenced
this pull request
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an integration test that runs the openapi linter vacuum on both the public and the internal API. It also fixes all the validation failures reported by the tool.
Checklist
changelog.d