Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WPB-11183 Remove wrong templates and make email sending no op #4315

Conversation

battermann
Copy link
Contributor

@battermann battermann commented Oct 29, 2024

The welcome email for a personal user who created a team and became the owner, was using the wrong template.
In this PR the wrong templates are deleted and the function for sending the welcome email is now doing nothing.
Also, I added some new types for the templates that we expect to use once they are ready.

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Oct 29, 2024
@battermann battermann marked this pull request as ready for review October 29, 2024 13:49
@battermann battermann changed the title WPB-11183 confirmation email after team creation and account migration of the team owner WPB-11183 Remove wrong templates and make email sending no op Oct 29, 2024
@battermann battermann merged commit 759eb92 into develop Oct 30, 2024
10 checks passed
@battermann battermann deleted the WPB-11183-be-confirmation-email-after-team-creation-and-account-migration-of-the-team-owner branch October 30, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: personal-users-to-team-users... ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants