Removing SoundManager2 dependency #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mythsunwind and @Yserz are thinking about writing tests which can read from the JS dev console if a sound started to play. So there needs to be a test which checks for this line: |
gregor
force-pushed
the
audio
branch
2 times, most recently
from
bdc153c
to
08696b4
Compare
|
Please take another look. Unit tests have been added. Positive cases are x'ed out due to karma-runner/karma#2320. |
| "sinon": "1.17.4" | ||
| "load-grunt-tasks": "3.5.2", | ||
| "request": "2.74.0", | ||
| "sinon": "1.17.5" |
| amplify.subscribe z.event.WebApp.AUDIO.PLAY_IN_LOOP, @, @_play_in_loop | ||
| amplify.subscribe z.event.WebApp.AUDIO.STOP, @, @_stop | ||
| init: (skip_preloading = false) => | ||
| @_init_sounds() |
There was a problem hiding this comment.
I would vote for preload with default value false
|
@mythsunwind To simplify the logging the final message to check for is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.