Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Testcontainers to 0.31.0 #40

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

vaihtovirta
Copy link
Contributor

@vaihtovirta vaihtovirta commented Jun 13, 2024

References

Bumped version of testcontainers to 0.31.0 and adjusted the code with the changed contract of testcontainers.CustomizeRequestOption

https://github.com/testcontainers/testcontainers-go/releases/tag/v0.31.0

⚠️ Breaking Changes
break: return error from Customize request option (testcontainers/testcontainers-go#2267) @stevenh

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

Copy link

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@mdelapenya
Copy link

@oleg-nenashev what is the release schedule for the module? Is this PR something that can be added to the new release?

Thanks in advance

@syanukov
Copy link

syanukov commented Aug 9, 2024

@oleg-nenashev what is the release schedule for the module? Is this PR something that can be added to the new release?

Thanks in advance

any update?

@oleg-nenashev
Copy link
Member

Sorry, I was on vacation and muted GitHub. Will look into it this we

@ninadingole
Copy link

There is also a new release to v0.32.0 for testcontainers-go, could we please also add that in this PR and release this? I am also stuck because of this issue and had to copy the source to make things work. Thank you!

Copy link
Member

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the patch!

@oleg-nenashev oleg-nenashev changed the title feat: Bump testcontainers to 0.31.0 Bump Testcontainers to 0.31.0 Aug 9, 2024
@oleg-nenashev oleg-nenashev merged commit ab31b3f into wiremock:main Aug 9, 2024
@oleg-nenashev
Copy link
Member

Released in https://github.com/wiremock/wiremock-testcontainers-go/releases/tag/v1.0.0-alpha-9

@vaihtovirta vaihtovirta deleted the feat-testcontainers-0-31 branch August 14, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants