Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration from template file #15

Closed
PFigs opened this issue Apr 29, 2019 · 0 comments · Fixed by #42
Closed

Configuration from template file #15

PFigs opened this issue Apr 29, 2019 · 0 comments · Fixed by #42
Labels
integration/docker Issues related to integration with docker

Comments

@PFigs
Copy link
Contributor

PFigs commented Apr 29, 2019

*Problem"
Currently the docker builds rely on an entry point to evaluate environment parameters that are meant for the transport or sink service. The entry point becomes rather complex and difficult to extend and mantain.

Proposal
Generate a settings.yaml/settings.ini file, based on the environment parameters. The template file will contain the default values and in case they are propagated, the final file will have the corresponding parameters.

@PFigs PFigs added the integration/docker Issues related to integration with docker label Jun 12, 2019
PFigs pushed a commit that referenced this issue Jun 18, 2019
This commit simplifies the building of docker images by
relying on a docker-comopse for each type of image.

It is still possible to reduce the build to a single
compose file + a shell script to set the correct
tags and paths. However this is left for future
consideration.

Closes #15 and #26
PFigs pushed a commit that referenced this issue Jun 18, 2019
This commit simplifies the building of docker images by
relying on a docker-comopse for each type of image.

It is still possible to reduce the build to a single
compose file + a shell script to set the correct
tags and paths. However this is left for future
consideration.

Closes #15 and #26
PFigs pushed a commit that referenced this issue Jul 8, 2019
This commit simplifies the building of docker images by
relying on a docker-comopse for each type of image.

It is still possible to reduce the build to a single
compose file + a shell script to set the correct
tags and paths. However this is left for future
consideration.

Closes #15 and #26
@PFigs PFigs closed this as completed in #42 Jul 8, 2019
PFigs added a commit that referenced this issue Jul 8, 2019
This commit simplifies the building of docker images by relying on a docker-compose for each type of image.

The dev is meant for development, whereas the x86 and arm targets are meant for release versions of each platform.

It is still possible to reduce the build to a single compose file + a shell script to set the correct tags and paths. However this is left for future consideration.

Closes #15 and #26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration/docker Issues related to integration with docker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant