Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix transport template #104

Merged
merged 2 commits into from
Jul 29, 2019
Merged

Fix transport template #104

merged 2 commits into from
Jul 29, 2019

Conversation

PFigs
Copy link
Contributor

@PFigs PFigs commented Jul 29, 2019 •
edited
Loading

Ensures that transport defaults are respected within the docker entrypoint.

@PFigs PFigs added interface/transport Issues related to the gateway transport interface integration/docker Issues related to integration with docker labels Jul 29, 2019
@PFigs PFigs requested a review from GwendalRaoul July 29, 2019 07:47
@PFigs PFigs self-assigned this Jul 29, 2019
Docker entrypoint: respect transport defaults
76e9b67 
This commit removes a few default variables set within the
transport template in use for the docker entrypoint.

In the future the template should also be removed in favour
of a strategy such as the one mentioned in issue #103.
@PFigs PFigs merged commit 21c9148 into master Jul 29, 2019
@PFigs PFigs deleted the fix-transport-template branch July 29, 2019 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GwendalRaoul GwendalRaoul GwendalRaoul approved these changes

Assignees

@PFigs PFigs

Labels
integration/docker Issues related to integration with docker interface/transport Issues related to the gateway transport interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PFigs @GwendalRaoul