Transport: fix last will message #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -54,11 +54,17 @@ def __init__( | |||
|
|
|||
| self.whitened_ep_filter = settings.whitened_endpoints_filter | |||
|
|
|||
| last_will_topic = TopicGenerator.make_status_topic(self.gw_id) | |||
| last_will_message = wirepas_messaging.gateway.api.StatusEvent( | |||
| self.gw_id, GatewayState.OFFLINE).payload | |||
There was a problem hiding this comment.
continuation line over-indented for hanging indent
This feature was broken probably during the mqtt abstraction. Last will message can only be set before the connect is called. Doing it after the connect had no effect so offline state was not sent anymore
GwendalRaoul
force-pushed
the
fix_last_will
branch
from
4ca3ea0
to
c8c5f00
Compare
PFigs
approved these changes
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature was broken probably during the mqtt abstraction.
Last will message can only be set before the connect is called.
Doing it after the connect had no effect so offline state was not sent
anymore