Update readme #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
April 11, 2019 16:03
This commit fixes a few style violations in the README file and adds instructions on how to clone the repo.
This commit updates the building instructions and files, in particular the ones related to the docker builds. See .ci for build-images.sh
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| docker build \ | ||
| --compress ${DOCKER_BUILD_CACHE} \ | ||
| -t ${DOCKER_IMAGE_NAME}:${DOCKER_IMAGE_TAG} . \ | ||
| -f ${DOCKER_FILE} ${DOCKER_BUILD_TARGET} \ | ||
| -f ${DOCKER_FILE} \ | ||
| ${DOCKER_BUILD_TARGET} \ |
There was a problem hiding this comment.
Double quote to prevent globbing and word splitting.
| @@ -130,8 +130,8 @@ function lxgw_deliverables | |||
|
|
|||
| # generates intruction files | |||
| rst2pdf deliverable/instructions.rst -o ${ENV_RELEASE_PATH}/docker/README.pdf | |||
| rst2pdf README.rst -o ${ENV_RELEASE_PATH}/native/README.pdf | |||
| rst2pdf README_release.rst -o ${ENV_RELEASE_PATH}/README.pdf | |||
| md2pdf README.md ${ENV_RELEASE_PATH}/native/README.pdf | |||
There was a problem hiding this comment.
Double quote to prevent globbing and word splitting.
| #!/usr/bin/env bash | ||
| # Wirepas Oy | ||
|
|
||
| source ./modules/git.sh |
There was a problem hiding this comment.
./modules/git.sh was not specified as input (see shellcheck -x).
added 2 commits
April 12, 2019 08:29
Now using the public Wirepas base images at: https://hub.docker.com/r/wirepas/base
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focus on clarifying how to clone the repo and how to build its images