-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/additional components #115
Merged
formatc1702
merged 30 commits into
wireviz:dev
from
Tyler-Ward:feature/additional_components
Oct 22, 2020
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
389e480
Add bom ignore option for cables and connectors
Tyler-Ward 84c9db6
Add connector aditional bom components
Tyler-Ward 064fbc6
Add support for connectioncount as a qty option
Tyler-Ward 6680e55
Clean up construction of connectors_extra list
Tyler-Ward 9a1bc20
Add extra components to connector nodes in graph
Tyler-Ward 1a8942a
Add support for cables to have extra components
Tyler-Ward 94d6fc9
Add units to graph output
Tyler-Ward bb37b37
Split qty into multiple fields
Tyler-Ward 668ee0a
Fix wrong designation in bom for cable additions
Tyler-Ward e852df5
Fix bad check for pn being set
Tyler-Ward 22e6fb5
Fix conector additions to multiply quantity rather than replace it
Tyler-Ward 983c322
Add error handling for missing type in additional components.
Tyler-Ward 0e929fe
Reformat aditional component rendering in conector and cable nodes
Tyler-Ward 038938c
Fix bugs from the the error handling additions.
Tyler-Ward 3e1e9b7
remove bom designators for connector extras with show_name=false
Tyler-Ward c6c54b0
Add Bom referenced parts lists for aditional components
Tyler-Ward 5170631
Update Tutorial 08 sources to include additional components
Tyler-Ward 7c67a9e
Implement suggested code cleanup
Tyler-Ward abcccbd
Move calculation of qty_multiplier into wv_helper
Tyler-Ward 3faaff6
Simplify several function calls and typehint qty multipliers
Tyler-Ward 20622e0
Move qty_multiplier functions into Connector and cable dataclasses
Tyler-Ward a450c82
Make description for additional components a property
Tyler-Ward cb3e3f4
Deduplicate additional components functions
Tyler-Ward b7f184e
Moved bom entry description generation to be in order of aperance
Tyler-Ward 715fe36
Remove brackets arround if statements and shorten bom dict opperatiions
Tyler-Ward e6c21bd
Fix issue with deduplication of connectors.
Tyler-Ward 5e0827b
Improve multiline field handling to avoid unwanted spaces
Tyler-Ward f128ea2
Add additional_components to the syntax documentation.
Tyler-Ward 052348c
Remove unused functions and code formatting tweaks
Tyler-Ward 4eeff65
Remove aditional component type capitilisation and swap to rstrip.
Tyler-Ward File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason the
Literal
s are commented out?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
from @kvid's comment #115 (comment)
I have checked my 2.7 install and literals aernt supported, doing some searching I cant find any reference to this method of specifying literals so not sure if this is a standard implementation method or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood. Let's keep it like this then, perhaps add a comment behind the comment explaining this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
New in version 3.8 is specified by https://docs.python.org/3/library/typing.html#typing.Literal