-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add version number to output files with meta info #177
Conversation
7d83db5
to
4f9de29
Compare
This is a good idea and I'm willing to include it in v0.2! |
3890a3a
to
ddbda98
Compare
I'm sorry that the two last commits are slightly off topic, but the reasoning is:
|
I appreciate the attention to detail, and I agree having a standardized way to write the app's name (WireViz) is good.
Hehe, I doubt this would have bothered anyone, and I doubt that the |
Tag the .gv and .html output files with generator and version number.
The application name and URL was defined several places in the code, and the name was not written exactly the same everywhere. By using the same constants everywhere, consistency is obtained.
The https://validator.w3.org/ reported Errors: The align attribute on the th/td element is obsolete. Use CSS instead. By replacing align="X" attributes with text-align:X; CSS equivalent, the validator now completes without any errors or warnings. This solves the remaining issues from wireviz#97.
ddbda98
to
f6d0f23
Compare
Looks good, couldn't find any remaining references that would need fixing. Much appreciated! |
This is a follow-up to the version number part of #173 to also tag the
.gv
and.html
output files with version number.The last few HTML validation errors remaining from #97 was also removed in the process.