Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic options and metadata #214

Merged
merged 12 commits into from
Aug 25, 2021
Merged

Commits on Aug 24, 2021

  1. Add basic metadata and options to Harness

    Resolves the basic part of wireviz#158.
    kvid committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    5d6d60c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2d6b1e3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    09243fb View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    66fdfc7 View commit details
    Browse the repository at this point in the history
  5. Add fontname option

    Use this option value both in the graph and as font family in HTML.
    kvid committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    5aac2ba View commit details
    Browse the repository at this point in the history
  6. Add bgcolor option

    The same color value is used for html.body.style.background-color
    and gv.graph.bgcolor to make the diagram fit seamlessly in the HTML
    output. "bgcolor" is chosen as option name to avoid the dash in the
    CSS name "background-color".
    kvid committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    22f20e2 View commit details
    Browse the repository at this point in the history
  7. Avoid transparent cable nodes

    Bug: Node attribute fillcolor is ignored unless style contains filled.
    When cable nodes get an empty style (unless bundle), the node background
    color become equal to the graph background color as it was transparent.
    
    Fix: Make the style contain filled.
    kvid committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    3223861 View commit details
    Browse the repository at this point in the history
  8. Avoid a node size greater than the HTML label

    Bug: When the HTML label is narrow (e.g. connectors in tutorial01),
    then the white node background is wider, and when the HTML label is
    low (e.g. ferrules in tutorial05 and totorial06), then the white
    node background is taller. Such errors are easily seen with a
    non-white bgcolor.
    
    Fix: Set node width, height, and margin to zero to let the actual
    size of the node be entirely determined by the label.
    kvid committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    84772fc View commit details
    Browse the repository at this point in the history
  9. Add bgcolor_node option

    It is default white unless set to a different color, or equal
    bgcolor (as if transparent) if set to ~, null, Null, or NULL.
    kvid committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    d5c6911 View commit details
    Browse the repository at this point in the history
  10. Change Metadata to a dict as requested by the owner

    And a few other changes requested in the same review.
    
    Co-authored-by: Daniel Rojas <[email protected]>
    kvid and formatc1702 committed Aug 24, 2021
    Configuration menu
    Copy the full SHA
    15d7374 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    b5e3d0a View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. Configuration menu
    Copy the full SHA
    e89e5c4 View commit details
    Browse the repository at this point in the history