-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic options and metadata #214
Merged
Merged
Commits on Aug 24, 2021
-
Add basic metadata and options to Harness
Resolves the basic part of wireviz#158.
Configuration menu - View commit details
-
Copy full SHA for 5d6d60c - Browse repository at this point
Copy the full SHA 5d6d60cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d6b1e3 - Browse repository at this point
Copy the full SHA 2d6b1e3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09243fb - Browse repository at this point
Copy the full SHA 09243fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 66fdfc7 - Browse repository at this point
Copy the full SHA 66fdfc7View commit details -
Use this option value both in the graph and as font family in HTML.
Configuration menu - View commit details
-
Copy full SHA for 5aac2ba - Browse repository at this point
Copy the full SHA 5aac2baView commit details -
The same color value is used for html.body.style.background-color and gv.graph.bgcolor to make the diagram fit seamlessly in the HTML output. "bgcolor" is chosen as option name to avoid the dash in the CSS name "background-color".
Configuration menu - View commit details
-
Copy full SHA for 22f20e2 - Browse repository at this point
Copy the full SHA 22f20e2View commit details -
Bug: Node attribute fillcolor is ignored unless style contains filled. When cable nodes get an empty style (unless bundle), the node background color become equal to the graph background color as it was transparent. Fix: Make the style contain filled.
Configuration menu - View commit details
-
Copy full SHA for 3223861 - Browse repository at this point
Copy the full SHA 3223861View commit details -
Avoid a node size greater than the HTML label
Bug: When the HTML label is narrow (e.g. connectors in tutorial01), then the white node background is wider, and when the HTML label is low (e.g. ferrules in tutorial05 and totorial06), then the white node background is taller. Such errors are easily seen with a non-white bgcolor. Fix: Set node width, height, and margin to zero to let the actual size of the node be entirely determined by the label.
Configuration menu - View commit details
-
Copy full SHA for 84772fc - Browse repository at this point
Copy the full SHA 84772fcView commit details -
It is default white unless set to a different color, or equal bgcolor (as if transparent) if set to ~, null, Null, or NULL.
Configuration menu - View commit details
-
Copy full SHA for d5c6911 - Browse repository at this point
Copy the full SHA d5c6911View commit details -
Change Metadata to a dict as requested by the owner
And a few other changes requested in the same review. Co-authored-by: Daniel Rojas <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 15d7374 - Browse repository at this point
Copy the full SHA 15d7374View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5e3d0a - Browse repository at this point
Copy the full SHA b5e3d0aView commit details
Commits on Aug 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for e89e5c4 - Browse repository at this point
Copy the full SHA e89e5c4View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.