Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Define a new dataclass with color and font attributes #255

Draft
wants to merge 5 commits into
base: dev
Choose a base branch
from
Draft

[feature] Define a new dataclass with color and font attributes #255

wants to merge 5 commits into from

Commits on Oct 22, 2021

  1. Import Color from the file it is now defined

    @kvid
    kvid committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    40aed9e View commit details
    Browse the repository at this point in the history

  2. Move color and font options into new Look dataclass 

    This solves the basic part of wireviz#225 - supporting options to specify
- Foreground/border color and text color in addition to bgcolor
- Font size is not requested in wireviz#225, but included as well
    @kvid
    kvid committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    251aab0 View commit details
    Browse the repository at this point in the history

  3. Replace bgcolor of node elements with box containing Look 

    In the elements: Image, AdditionalComponent, Connector, and Cable.
    @kvid
    kvid committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    bb39a12 View commit details
    Browse the repository at this point in the history

  4. Rename Look attribute color to bordercolor

    @kvid
    kvid committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    8e09cb9 View commit details
    Browse the repository at this point in the history

  5. Make Options inherit from Look 

    Avoid the extra base part of the data structure.
    @kvid
    kvid committed Oct 22, 2021
    Configuration menu
    Copy the full SHA
    c87f073 View commit details
    Browse the repository at this point in the history