Avoid decimal point and trailing zero for integer BOM quantities #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
approved these changes
Jun 4, 2024
kvid
added a commit
that referenced
this pull request
Jun 7, 2024
kvid
added a commit
that referenced
this pull request
Jun 12, 2024
Closed
kvid
added a commit
that referenced
this pull request
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the total length of certain items in the BOM will be shown with a decimal point and a trailing zero even if all values are input as integers. One source of this is https://github.com/wireviz/WireViz/blob/v0.4/src/wireviz/DataClasses.py#L310 where an integer value will be converted to a float value, but there might be other places in the code that could cause the same issue.
This change will resolve the issue at the other end (while processing the BOM) - independently of what might be the source of the issue. This should fix #340.