Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to WireViz 0.3 #3

Merged
merged 7 commits into from
Oct 22, 2021
Merged

Upgrade to WireViz 0.3 #3

merged 7 commits into from
Oct 22, 2021

Conversation

amotl
Copy link
Member

@amotl amotl commented Oct 22, 2021

Hi there,

@formatc1702 released WireViz 0.3 a few days ago. This patch adjusts WireViz-Web to the corresponding changes.

With kind regards,
Andreas.

1. The `bom_list()` function has to be used explicitly
2. The output gained another column "Id"
3. The output column "Item" was renamed to "Description"
4. Output items apparently get sorted now, so "Cable" goes first
@codecov
Copy link

codecov bot commented Oct 22, 2021

Codecov Report

Merging #3 (3a51704) into main (e869838) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main        #3   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          154       162    +8     
=========================================
+ Hits           154       162    +8     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wireviz_web/core.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e869838...3a51704. Read the comment docs.

Instead of propagating the "title" using `file_out`, inject a default
title into the ingress YAML payload. This makes `file_out` non-mandatory
again.
@amotl amotl merged commit ebc9adf into main Oct 22, 2021
@amotl amotl deleted the amo/upgrade-wireviz branch October 22, 2021 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant