Skip to content

Commit

Permalink
fix(astro): build config from astro conflict with vite.config.js (#8852)
Browse files Browse the repository at this point in the history
* fix: config from astro conflict with vite

* refactor: apply config on AstroBuilder.setup
  • Loading branch information
rayriffy authored Oct 18, 2023
1 parent 3baab3d commit 2c18e2d
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/fresh-lizards-whisper.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'astro': patch
---

Only use Vite config from astro.config.mjs as source of truth
2 changes: 2 additions & 0 deletions packages/astro/src/core/create-vite.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,8 @@ export async function createVite(

// Start with the Vite configuration that Astro core needs
const commonConfig: vite.InlineConfig = {
// Tell Vite not to combine config from vite.config.js with our provided inline config
configFile: false,
cacheDir: fileURLToPath(new URL('./node_modules/.vite/', settings.config.root)), // using local caches allows Astro to be used in monorepos, etc.
clearScreen: false, // we want to control the output, not Vite
logLevel: 'warn', // log warnings and errors only
Expand Down

0 comments on commit 2c18e2d

Please sign in to comment.