Skip JSX tagging for export statements with source (#5057)

withastro · Oct 12, 2022 · baf88ee · baf88ee
1 parent 8d2d0c3
commit baf88ee
Show file tree

Hide file tree

Showing 6 changed files with 17 additions and 2 deletions.
diff --git a/.changeset/serious-icons-dream.md b/.changeset/serious-icons-dream.md
@@ -0,0 +1,5 @@
+---
+'astro': patch
+---
+
+Skip JSX tagging for export statements with source
diff --git a/packages/astro/src/vite-plugin-jsx/tag.ts b/packages/astro/src/vite-plugin-jsx/tag.ts
@@ -104,7 +104,7 @@ export default function tagExportsWithRenderer({
 									addTag(property.key.name);
 								}
 							});
-						} else if (t.isExportNamedDeclaration(node)) {
+						} else if (t.isExportNamedDeclaration(node) && !node.source) {
 							node.specifiers.forEach((specifier) => {
 								if (t.isExportSpecifier(specifier) && t.isIdentifier(specifier.exported)) {
 									addTag(specifier.local.name);

diff --git a/packages/astro/test/fixtures/react-jsx-export/src/components/ListExportTest.jsx b/packages/astro/test/fixtures/react-jsx-export/src/components/ListExportTest.jsx
@@ -1,5 +1,7 @@
 import { useState } from "react"
 
+export { ListExportTestComponent } from './ListExportTestComponent'
+
 const ListExport = () => {
     const [example] = useState('Example')
     return <h2 id="default_list_export">{example}</h2>

diff --git a/packages/astro/test/fixtures/react-jsx-export/src/components/ListExportTestComponent.jsx b/packages/astro/test/fixtures/react-jsx-export/src/components/ListExportTestComponent.jsx
@@ -0,0 +1,6 @@
+import { useState } from "react"
+
+export const ListExportTestComponent = () => {
+  const [example] = useState('Example')
+  return <h2 id="list_export_test_component">{example}</h2>
+}
diff --git a/packages/astro/test/fixtures/react-jsx-export/src/pages/index.astro b/packages/astro/test/fixtures/react-jsx-export/src/pages/index.astro
@@ -1,5 +1,5 @@
 ---
-import ListAsDefaultExport, {ListExport, RenamedListExport} from '../components/ListExportTest'
+import ListAsDefaultExport, {ListExport, RenamedListExport, ListExportTestComponent} from '../components/ListExportTest'
 import {ConstDeclarationExport, LetDeclarationExport, FunctionDeclarationExport} from '../components/DeclarationExportTest'
 import AnonymousArrowDefaultExport from '../components/defaultExport/AnonymousArrowDefaultExport'
 import AnonymousFunctionDefaultExport from '../components/defaultExport/AnonymousFunctionDefaultExport'
@@ -12,6 +12,7 @@ import NamedFunctionDefaultExport from '../components/defaultExport/NamedFunctio
 <ListAsDefaultExport />
 <ListExport />
 <RenamedListExport />
+<ListExportTestComponent />
 
 <ConstDeclarationExport />
 <LetDeclarationExport />

diff --git a/packages/astro/test/react-jsx-export.test.js b/packages/astro/test/react-jsx-export.test.js
@@ -17,6 +17,7 @@ describe('react-jsx-export', () => {
 		'default_list_export',
 		'renamed_list_export',
 		'list_as_default_export',
+		'list_export_test_component',
 	];
 
 	const reactInvalidHookWarning =