🐛 BUG: `astro add` could not update config file safely #3071

lucywho · 2022-04-11T09:34:48Z

What version of `astro` are you using?

1.0.0-beta.7

Are you using an SSR adapter? If so, which one?

none

What package manager are you using?

npm

What operating system are you using?

Linux

Describe the Bug

Set up a new astro project using Minimal template

Attempted to install tailwindcss using npx astro add tailwind

Got error message error Astro could not update your astro.config.js file safely. Reason: t.identifier is not a function

Link to Minimal Reproducible Example

I have no idea how to do this

Participation

I am willing to submit a pull request for this issue.

The text was updated successfully, but these errors were encountered:

tony-sull · 2022-04-12T08:14:31Z

@lucywho can you share the package.json and Astro config file?

The message mentions astro.config.js but the minimal template uses astro.config.mjs, if the Astro config file is using an outdated format astro add may not know how to update it properly 🤔

lucywho · 2022-04-12T09:34:52Z

@tony-sull

astro.config.mjs

import { defineConfig } from 'astro/config';
 
 // https://astro.build/config
 export default defineConfig({});

package.json


 {
  "name": "@example/minimal",
  "version": "0.0.1",
  "private": true,
  "scripts": {
    "dev": "astro dev",
    "start": "astro dev",
    "build": "astro build",
    "preview": "astro preview"
  },
  "devDependencies": {
    "astro": "^1.0.0-beta.8"
  }
}

tony-sull · 2022-04-12T14:12:18Z

Interesting, I just ran this locally (below) and didn't hit an issue. @lucywho can you reproduce it in one of the astro.new starters in Stackblitz?

npm init astro -- --template minimal minimal
cd minimal && npm i
npx astro add tailwind

lucywho · 2022-04-13T08:41:41Z

Looks like it works fine in Stackblitz.

ghost · 2022-04-13T22:26:29Z

I got the same error and my astro.config.mjs and package.json are the same as Lucywho's with the exception of my package.json says beta.9 instead of 8

MarkJamesHoward · 2022-04-17T03:25:51Z

Seeing the same myself on beta 14 now. Feels like maybe something being cached as I had this a while back and it resolved itself at some point, but happening again now. And works fine on my laptop.

MarkJamesHoward · 2022-04-18T08:07:00Z

This looks to be related to an outdated version on Node. Works fine on my laptop with Node v16.14 and was seeing the [t.identifier] error on my PC that had Node v14.16.1. Downgraded my laptop to Node 14.16.1 and reproduced the error. The change I made to fix this was (which is no longer needed as we just need to update to Node v16.14) was to import from @babel/types using explicit imports. @babel/types is a commonJS package and as such the latest import that we use (import * as t from @babel/types) does not work on older versions it seems.

@lucywho @Web-Dev-Taz could you check which version of Node you have to confirm maybe?

lucywho · 2022-04-19T07:31:23Z

I've got Node v 16.14.2, so its not that unfortunately

MarkJamesHoward · 2022-04-21T22:08:56Z

Looks like multiple things can affect the import from Babel with yours still showing the issue I guess. I can't reproduce since my node upgrade I'm afraid though sorry. Before my node upgrade I managed to get it working by explicitly importing from babel types - one option there I guess if you need to run..

FredKSchott · 2022-05-10T19:02:02Z

I can't reproduce, sorry! If anyone can track down a solid reproduction, we can take a look, but it's hard to debug without knowing.

Otherwise, if you can reproduce and feel comfortable putting some console logs inside of your node_modules/astro folder, then we'd love some help tracking this down! If t.identifier is not a function, can you add a console.log(t) to share what it is? searching the node_modules/astro folder for .identifier( should help you find where the error is.

nicktaylor · 2022-06-30T12:48:38Z

@FredKSchott I'm having this same issue. I simply ran npc create astro@latest entering . as the new location to create the project, selecting just the basics and "yes" to run npm install, "yes" to create git folder.

When I then run npx astro add svelte I get the t.identifier issue above. This occurs on line number 85 of /dist/core/add/index.js which is const defineConfig = t.identifier("defineConfig");.

Here's what t is at that time https://gist.github.com/nicktaylor/b72cbaffdb7c5acac11ae8fd3c0e39b6

Within babel.js changing this to export t.default resolves the issue and things work normally:

"use strict";
import generator from "@babel/generator";
import parser from "@babel/parser";
import traverse from "@babel/traverse";
import {default as t} from "@babel/types"; // Updated this line to set default as t
const visit = traverse.default;
async function generate(ast) {
  const astToText = generator.default;
  const { code } = astToText(ast);
  return code;
}
const parse = (code) => parser.parse(code, { sourceType: "unambiguous", plugins: ["typescript"] });
export {
  generate,
  parse,
  t,
  visit
}

NPM Version: 6.14.8
Node Version: 14.15.1

Used nvm to change node versions to the following, at it worked fine:

NPM Version: 8.13.2
Node Version: 16.15.1

natemoo-re · 2022-07-08T20:16:35Z

Thanks for digging into this, everyone! We have the infrastructure in place to give you helpful warnings when you're using an incompatible version of Node, but our engines field was out of date so the warnings were never triggered.

I opened #3871 to update those fields.

Co-authored-by: Nate Moore <[email protected]>

Tsourdox · 2022-08-22T20:35:36Z

Updating node to 16 solved it for me :)

sramam · 2022-09-20T05:43:19Z

It seems an attempt to install astro within a turbo (mono)repo fails with this error.

Versions

❯ npm -v
8.15.0
❯ node -v
v16.17.0

Script to reproduce

#!/usr/bin/env sh

CWD=`pwd`

TURBO_PROJECT=turbo-sample
UI_APP=astro-app

# setup turbo repo
npx create-turbo@latest $TURBO_PROJECT
cd $CWD/$TURBO_PROJECT

rm -rf apps/$UI_APP
mkdir -p apps/$UI_APP
cd $CWD/$TURBO_PROJECT/apps/$UI_APP
# setup astro project
npm create astro@latest
# select '.' for a directory

# add astro plugins
npm run astro add svelte
npm run astro add tailwind

cd $CWD

Expectation

These commands succeed.

npm run astro add svelte
npm run astro add tailwind

Actual

It seems that npm installs dependencies in the monorepo root, so there is a missing package-lock.json in the astro repo.
This seems to be causing the astro installer to default to using yarn. But that hangs.

If I CTRL-C out of the install section, it'll update the astro.config.mjs.
If I hit enter, it'll fail with

 error   Astro could not update your astro.config.js file safely.1ms
  Reason: Unable to install dependencies

  You will need to add these integration(s) manually.
  Documentation: https://docs.astro.build/en/guides/integrations-guide/

Complete run log

❯ rm -rf /tmp/turbo-sample && ./astro-bug.sh

>>> TURBOREPO

>>> Welcome to Turborepo! Let's get you set up with a new codebase.

? Which package manager do you want to use? npm

>>> Created a new turborepo with the following:

 - apps/web: Next.js with TypeScript
 - apps/docs: Next.js with TypeScript
 - packages/ui: Shared React component library
 - packages/eslint-config-custom: Shared configuration (ESLint)
 - packages/tsconfig: Shared TypeScript `tsconfig.json`

>>> Success! Created a new Turborepo at "turbo-sample".
Inside that directory, you can run several commands:

  npm run build
     Build all apps and packages

  npm run dev
     Develop all apps and packages

Turborepo will cache locally by default. For an additional
speed boost, enable Remote Caching with Vercel by
entering the following command:

  npx turbo login

We suggest that you begin by typing:

  cd turbo-sample
  npx turbo login


Welcome to Astro! (create-astro v1.0.1)
Lets walk through setting up your new Astro project.

✔ Where would you like to create your new project? … .
✔ Which template would you like to use? › Just the basics (recommended)
✔ Template copied!
✔ Would you like to install npm dependencies? (recommended) … yes
✔ Packages installed!
✔ Would you like to initialize a new git repository? (optional) … no
ℹ Sounds good! You can come back and run git init later.
✔ How would you like to setup TypeScript? › Strictest
✔ TypeScript settings applied!
✔ Setup complete.
✔ Ready for liftoff!

 Next steps

You can now cd into the  project directory.
Run npm run dev to start the Astro dev server. CTRL-C to close.
Add frameworks like react and tailwind to your project using astro add

Stuck? Come join us at https://astro.build/chat
Good luck out there, astronaut.

npm WARN ignoring workspace config at /private/tmp/turbo-sample/apps/astro-app/.npmrc

> @example/[email protected] astro
> astro

✔ Resolving packages...

  Astro will run the following command:
  If you skip this step, you can always run it yourself later

 ╭──────────────────────────────────────────╮
 │ yarn add @astrojs/svelte svelte@^3.46.4  │
 ╰──────────────────────────────────────────╯

✖ Continue? … yes

   cancelled  Dependencies NOT installed.

  ▶ Be sure to install them manually before continuing!

  Astro will make the following changes to your config file:

 ╭ astro.config.mjs ─────────────────────────────╮
 │ import { defineConfig } from 'astro/config';  │
 │                                               │
 │ import svelte from "@astrojs/svelte";         │
 │                                               │
 │ // https://astro.build/config                 │
 │ export default defineConfig({                 │
 │   integrations: [svelte()]                    │
 │ });                                           │
 ╰───────────────────────────────────────────────╯

✔ Continue? … yes

   success  Added the following integration to your project:
  - @astrojs/svelte
npm WARN ignoring workspace config at /private/tmp/turbo-sample/apps/astro-app/.npmrc

> @example/[email protected] astro
> astro

✔ Resolving packages...

  Astro will run the following command:
  If you skip this step, you can always run it yourself later

 ╭─────────────────────────────────────────────────╮
 │ yarn add @astrojs/tailwind tailwindcss@^3.0.24  │
 ╰─────────────────────────────────────────────────╯

✔ Continue? … yes
✖ Installing dependencies...
 error   Astro could not update your astro.config.js file safely.1ms
  Reason: Unable to install dependencies

  You will need to add these integration(s) manually.
  Documentation: https://docs.astro.build/en/guides/integrations-guide/
Error: Astro could not update your astro.config.js file safely.
Reason: Unable to install dependencies

You will need to add these integration(s) manually.
Documentation: https://docs.astro.build/en/guides/integrations-guide/
    at add (file:///private/tmp/turbo-sample/node_modules/astro/dist/core/add/index.js:140:31)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async runCommand (file:///private/tmp/turbo-sample/node_modules/astro/dist/cli/index.js:112:14)
    at async cli (file:///private/tmp/turbo-sample/node_modules/astro/dist/cli/index.js:207:5)
npm ERR! Lifecycle script `astro` failed with error:
npm ERR! Error: command failed
npm ERR!   in workspace: @example/[email protected]
npm ERR!   at location: /private/tmp/turbo-sample/apps/astro-app

jarrodjperez · 2022-09-20T16:30:34Z

@sramam I ran into this as well, but running pnpm install within the astro project directory first fixed it for me.

Co-authored-by: Nate Moore <[email protected]>

AlkenD · 2023-07-16T17:29:42Z

It seems an attempt to install astro within a turbo (mono)repo fails with this error.

Versions

❯ npm -v
8.15.0
❯ node -v
v16.17.0

Script to reproduce

#!/usr/bin/env sh

CWD=`pwd`

TURBO_PROJECT=turbo-sample
UI_APP=astro-app

# setup turbo repo
npx create-turbo@latest $TURBO_PROJECT
cd $CWD/$TURBO_PROJECT

rm -rf apps/$UI_APP
mkdir -p apps/$UI_APP
cd $CWD/$TURBO_PROJECT/apps/$UI_APP
# setup astro project
npm create astro@latest
# select '.' for a directory

# add astro plugins
npm run astro add svelte
npm run astro add tailwind

cd $CWD

Expectation

These commands succeed.

npm run astro add svelte
npm run astro add tailwind

Actual

It seems that npm installs dependencies in the monorepo root, so there is a missing package-lock.json in the astro repo. This seems to be causing the astro installer to default to using yarn. But that hangs.

If I CTRL-C out of the install section, it'll update the astro.config.mjs. If I hit enter, it'll fail with

 error   Astro could not update your astro.config.js file safely.1ms
  Reason: Unable to install dependencies

  You will need to add these integration(s) manually.
  Documentation: https://docs.astro.build/en/guides/integrations-guide/

Complete run log

❯ rm -rf /tmp/turbo-sample && ./astro-bug.sh

>>> TURBOREPO

>>> Welcome to Turborepo! Let's get you set up with a new codebase.

? Which package manager do you want to use? npm

>>> Created a new turborepo with the following:

 - apps/web: Next.js with TypeScript
 - apps/docs: Next.js with TypeScript
 - packages/ui: Shared React component library
 - packages/eslint-config-custom: Shared configuration (ESLint)
 - packages/tsconfig: Shared TypeScript `tsconfig.json`

>>> Success! Created a new Turborepo at "turbo-sample".
Inside that directory, you can run several commands:

  npm run build
     Build all apps and packages

  npm run dev
     Develop all apps and packages

Turborepo will cache locally by default. For an additional
speed boost, enable Remote Caching with Vercel by
entering the following command:

  npx turbo login

We suggest that you begin by typing:

  cd turbo-sample
  npx turbo login


Welcome to Astro! (create-astro v1.0.1)
Lets walk through setting up your new Astro project.

✔ Where would you like to create your new project? … .
✔ Which template would you like to use? › Just the basics (recommended)
✔ Template copied!
✔ Would you like to install npm dependencies? (recommended) … yes
✔ Packages installed!
✔ Would you like to initialize a new git repository? (optional) … no
ℹ Sounds good! You can come back and run git init later.
✔ How would you like to setup TypeScript? › Strictest
✔ TypeScript settings applied!
✔ Setup complete.
✔ Ready for liftoff!

 Next steps

You can now cd into the  project directory.
Run npm run dev to start the Astro dev server. CTRL-C to close.
Add frameworks like react and tailwind to your project using astro add

Stuck? Come join us at https://astro.build/chat
Good luck out there, astronaut.

npm WARN ignoring workspace config at /private/tmp/turbo-sample/apps/astro-app/.npmrc

> @example/[email protected] astro
> astro

✔ Resolving packages...

  Astro will run the following command:
  If you skip this step, you can always run it yourself later

 ╭──────────────────────────────────────────╮
 │ yarn add @astrojs/svelte svelte@^3.46.4  │
 ╰──────────────────────────────────────────╯

✖ Continue? … yes

   cancelled  Dependencies NOT installed.

  ▶ Be sure to install them manually before continuing!

  Astro will make the following changes to your config file:

 ╭ astro.config.mjs ─────────────────────────────╮
 │ import { defineConfig } from 'astro/config';  │
 │                                               │
 │ import svelte from "@astrojs/svelte";         │
 │                                               │
 │ // https://astro.build/config                 │
 │ export default defineConfig({                 │
 │   integrations: [svelte()]                    │
 │ });                                           │
 ╰───────────────────────────────────────────────╯

✔ Continue? … yes

   success  Added the following integration to your project:
  - @astrojs/svelte
npm WARN ignoring workspace config at /private/tmp/turbo-sample/apps/astro-app/.npmrc

> @example/[email protected] astro
> astro

✔ Resolving packages...

  Astro will run the following command:
  If you skip this step, you can always run it yourself later

 ╭─────────────────────────────────────────────────╮
 │ yarn add @astrojs/tailwind tailwindcss@^3.0.24  │
 ╰─────────────────────────────────────────────────╯

✔ Continue? … yes
✖ Installing dependencies...
 error   Astro could not update your astro.config.js file safely.1ms
  Reason: Unable to install dependencies

  You will need to add these integration(s) manually.
  Documentation: https://docs.astro.build/en/guides/integrations-guide/
Error: Astro could not update your astro.config.js file safely.
Reason: Unable to install dependencies

You will need to add these integration(s) manually.
Documentation: https://docs.astro.build/en/guides/integrations-guide/
    at add (file:///private/tmp/turbo-sample/node_modules/astro/dist/core/add/index.js:140:31)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async runCommand (file:///private/tmp/turbo-sample/node_modules/astro/dist/cli/index.js:112:14)
    at async cli (file:///private/tmp/turbo-sample/node_modules/astro/dist/cli/index.js:207:5)
npm ERR! Lifecycle script `astro` failed with error:
npm ERR! Error: command failed
npm ERR!   in workspace: @example/[email protected]
npm ERR!   at location: /private/tmp/turbo-sample/apps/astro-app

it appears I'm facing a similar issue with the turborepo setup with regards to pnpm-lock.yaml file in my case if I create a standalone project it works without any issue but if I install it in a mono repo env it fails to add astro integrations, by any chance did u find a fix for it ?

rverton · 2023-08-01T07:08:44Z

I also run into this bug with workspaces an Astro. To reproduce:

npm init
npm init -w ./packages/web
rm ./packages/web/package.json (so create-astro can run in an empty folder)
cd ./packages/web/ && npx create-astro@latest and confirm each question
npm run astro add tailwind

This results in:

✔ Continue? … yes
✖ Installing dependencies...
 error   Astro could not update your astro.config.js file safely.
  Reason: Unable to install dependencies

  You will need to add these integration(s) manually.
  Documentation: https://docs.astro.build/en/guides/integrations-guide/
  File:
    /private/tmp/astro-workspaces/node_modules/astro/dist/cli/add/index.js:170:31
  Code:
    169 |     case 3 /* failure */: {
    > 170 |       throw createPrettyError(new Error(`Unable to install dependencies`));
          |                               ^
      171 |     }
      172 |   }
      173 |   const rawConfigPath = await resolveConfigPath({ cwd, flags, fs: fsMod });
  Stacktrace:
Error: Astro could not update your astro.config.js file safely.
Reason: Unable to install dependencies

You will need to add these integration(s) manually.
Documentation: https://docs.astro.build/en/guides/integrations-guide/
    at add (file:///private/tmp/astro-workspaces/node_modules/astro/dist/cli/add/index.js:170:31)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at async runCommand (file:///private/tmp/astro-workspaces/node_modules/astro/dist/cli/index.js:103:7)
    at async cli (file:///private/tmp/astro-workspaces/node_modules/astro/dist/cli/index.js:155:5)

@tony-sull I'm not able to reopen this issue here, but I dont want to create a new issue to keep it relevant to the discussion here.

xn1cklas · 2023-10-02T06:38:35Z

Can confirm, it seems to be related with workspaces or something. Ran into this in a turbo monorepo with pnpm workspaces

zohaibakber · 2023-10-07T19:22:58Z

Still getting this error in sst monorepo @nsquaredotone did you find any solution to this?

prodkt · 2023-11-20T00:26:06Z

Same issue in an Astro Turborepo. Node 18, Astro 3.3.5. I don't see a resolution in this thread, but there must be if its closed. For those of us coming in down the line please present path to accurate implementation.

ronking159 · 2024-08-13T14:47:01Z

Got the same issue using Bun 1.1.22. I am using Fedora Linux.

xabru · 2024-08-21T05:14:05Z

Got the same issue using Bun 1.1.24. I am using Ubuntu Linux.

tony-sull changed the title ~~🐛 BUG:~~ 🐛 BUG: astro add could not update config file safely Apr 12, 2022

delucis mentioned this issue Apr 19, 2022

🐛 BUG: #3145

Closed

1 task

FredKSchott added the bb:investigate label May 10, 2022

FredKSchott added - P1: chore Doesn't change code behavior (priority) s1-small needs response Issue needs response from OP and removed bb:investigate labels May 10, 2022

natemoo-re added a commit that referenced this issue Jul 8, 2022

fix(#3071): update supported node versions

ec6934e

natemoo-re mentioned this issue Jul 8, 2022

Update supported node versions #3871

Merged

natemoo-re closed this as completed in #3871 Jul 11, 2022

natemoo-re added a commit that referenced this issue Jul 11, 2022

fix(#3071): update supported node versions (#3871)

1cc5b78

Co-authored-by: Nate Moore <[email protected]>

SiriousHunter pushed a commit to SiriousHunter/astro that referenced this issue Feb 3, 2023

fix(withastro#3071): update supported node versions (withastro#3871)

ba983ff

Co-authored-by: Nate Moore <[email protected]>

rverton mentioned this issue Aug 2, 2023

astro add fails when in a npm workspace #7925

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🐛 BUG: `astro add` could not update config file safely #3071

🐛 BUG: `astro add` could not update config file safely #3071

lucywho commented Apr 11, 2022

tony-sull commented Apr 12, 2022

lucywho commented Apr 12, 2022

tony-sull commented Apr 12, 2022

lucywho commented Apr 13, 2022

ghost commented Apr 13, 2022 •

edited by ghost

Loading

MarkJamesHoward commented Apr 17, 2022

MarkJamesHoward commented Apr 18, 2022 •

edited

Loading

lucywho commented Apr 19, 2022

MarkJamesHoward commented Apr 21, 2022

FredKSchott commented May 10, 2022

nicktaylor commented Jun 30, 2022 •

edited

Loading

natemoo-re commented Jul 8, 2022

Tsourdox commented Aug 22, 2022

sramam commented Sep 20, 2022 •

edited

Loading

jarrodjperez commented Sep 20, 2022 •

edited

Loading

AlkenD commented Jul 16, 2023

Versions

Script to reproduce

Expectation

Actual

Complete run log

rverton commented Aug 1, 2023 •

edited

Loading

xn1cklas commented Oct 2, 2023

zohaibakber commented Oct 7, 2023

prodkt commented Nov 20, 2023

ronking159 commented Aug 13, 2024

xabru commented Aug 21, 2024

🐛 BUG: astro add could not update config file safely #3071

🐛 BUG: astro add could not update config file safely #3071

Comments

lucywho commented Apr 11, 2022

What version of astro are you using?

Are you using an SSR adapter? If so, which one?

What package manager are you using?

What operating system are you using?

Describe the Bug

Link to Minimal Reproducible Example

Participation

tony-sull commented Apr 12, 2022

lucywho commented Apr 12, 2022

astro.config.mjs

package.json

tony-sull commented Apr 12, 2022

lucywho commented Apr 13, 2022

ghost commented Apr 13, 2022 • edited by ghost Loading

MarkJamesHoward commented Apr 17, 2022

MarkJamesHoward commented Apr 18, 2022 • edited Loading

lucywho commented Apr 19, 2022

MarkJamesHoward commented Apr 21, 2022

FredKSchott commented May 10, 2022

nicktaylor commented Jun 30, 2022 • edited Loading

natemoo-re commented Jul 8, 2022

Tsourdox commented Aug 22, 2022

sramam commented Sep 20, 2022 • edited Loading

Versions

Script to reproduce

Expectation

Actual

Complete run log

jarrodjperez commented Sep 20, 2022 • edited Loading

AlkenD commented Jul 16, 2023

Versions

Script to reproduce

Expectation

Actual

Complete run log

rverton commented Aug 1, 2023 • edited Loading

xn1cklas commented Oct 2, 2023

zohaibakber commented Oct 7, 2023

prodkt commented Nov 20, 2023

ronking159 commented Aug 13, 2024

xabru commented Aug 21, 2024

🐛 BUG: `astro add` could not update config file safely #3071

🐛 BUG: `astro add` could not update config file safely #3071

What version of `astro` are you using?

ghost commented Apr 13, 2022 •

edited by ghost

Loading

MarkJamesHoward commented Apr 18, 2022 •

edited

Loading

nicktaylor commented Jun 30, 2022 •

edited

Loading

sramam commented Sep 20, 2022 •

edited

Loading

jarrodjperez commented Sep 20, 2022 •

edited

Loading

rverton commented Aug 1, 2023 •

edited

Loading