Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improves client:only error message #10470

Merged
merged 6 commits into from
Apr 2, 2024

Conversation

liruifengv
Copy link
Member

@liruifengv liruifengv commented Mar 18, 2024

Changes

improves client:only error message

When set client:only="react" correctly, but not use @astrojs/react Integration, will get the error: https://docs.astro.build/en/reference/errors/no-client-only-hint/

  • added clientOnlyValues set for check passedname
  • throw different error by whether provide correct client:only directive
  • Give a warning if provide incorrect client:only directive but find the renderer by guess

Testing

Docs

Copy link

changeset-bot bot commented Mar 18, 2024

🦋 Changeset detected

Latest commit: cb7a765

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 18, 2024
@matthewp matthewp merged commit 320c309 into withastro:main Apr 2, 2024
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Apr 2, 2024
@liruifengv liruifengv deleted the fix-client-only-hint branch April 3, 2024 00:37
@liruifengv liruifengv restored the fix-client-only-hint branch April 3, 2024 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants