-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: make 3rd party integration warning less scary #10496
Conversation
🦋 Changeset detectedLatest commit: be7b367 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I believe that |
Scary may not be the term but this is following a discussion on discord with ben. See https://discord.com/channels/830184174198718474/1197638002764152843/1219466148567973918 for context |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! And to your comment @ematipico, I agree we should have a warning prompt before a user installs a third party integration. However, the addition of "Use at your own risk!" implies the user is doing something wrong by installing a third party integration. They are not! We have a large integration community, and we should keep the warning to just "This is not an official Astro integration. Continue?"
100% agree, I personally kinda felt the "use at your own risk" meant your now "outside of the scope of the withAstro viewpoint" even if they were packages that could be common use among MANY of the community members (Expressive Code for example) |
Changes
astro add
with a 3rd party integration. It does not remove any checkTesting
N/A
Docs
N/A